public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Michael Krufky <mkrufky@linuxtv.org>,
	linux-kernel@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: [PATCH] gitweb: Make shortlog use 'h' (head) parameter again
Date: Wed,  3 Jan 2007 21:30:04 +0100	[thread overview]
Message-ID: <11678562042320-git-send-email-jnareb@gmail.com> (raw)
In-Reply-To: <459C0232.3090804@linuxtv.org>

This fixes typo in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Michael Krufky wrote:

> Ever since gitweb on kernel.org was recently updated, I've been experiencing a
> nasty bug -- It seems that it is no longer possible to view a shortlog from any
> branch or head other than master.
[...]
> "log" and "tree" is working properly -- it seems that "shortlog" is the only
> feature affected by this bug.

This corrects this bug.  When introducing parse_commits to shortlog,
there was typo in parse_commits arguments: it was $head instead of $hash.

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 2ead917..2179054 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4423,7 +4423,7 @@ sub git_shortlog {
 	}
 	my $refs = git_get_references();
 
-	my @commitlist = parse_commits($head, 101, (100 * $page));
+	my @commitlist = parse_commits($hash, 101, (100 * $page));
 
 	my $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));
 	my $next_link = '';
-- 
1.4.4.3


      parent reply	other threads:[~2007-01-03 20:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-03 19:21 GITWEB branch shortlog broken after recent update on kernel.org Michael Krufky
2007-01-03 20:25 ` [PATCH] gitweb: Fix shortlog only showing HEAD revision Robert Fitzsimons
2007-01-03 20:36   ` Jakub Narebski
2007-01-05 21:21   ` Michael Krufky
2007-01-05 21:25     ` J.H.
2007-01-03 20:30 ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11678562042320-git-send-email-jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox