Re: [PATCH 2/2] watchdog: jz4740: Add DT support

Arnd Bergmann
2015-01-27T21:24:14Z

On Tuesday 27 January 2015 12:54:30 Guenter Roeck wrote:
> On Tue, Jan 27, 2015 at 09:15:37PM +0100, Arnd Bergmann wrote:
> > On Tuesday 27 January 2015 15:11:30 Zubair Lutfullah Kakakhel wrote:
> > > };
> > >
> > > +#ifdef CONFIG_OF
> > > +static const struct of_device_id jz4740_of_matches[] = {
> > > + { .compatible = "ingenic,jz4740-watchdog", },
> > > + { /* sentinel */ }
> > > +};
> > > +#endif
> > > +
> > > static int jz4740_wdt_probe(struct platform_device *pdev)
> > > {
> > > struct jz4740_wdt_drvdata *drvdata;
> > > @@ -211,6 +219,7 @@ static struct platform_driver jz4740_wdt_driver = {
> > > .remove = jz4740_wdt_remove,
> > > .driver = {
> > > .name = "jz4740-wdt",
> > > + .of_match_table = of_match_ptr(jz4740_of_matches),
> > > },
> > >
> >
> > Why the #ifdef? Presumably we want to move over jz4740 to DT-only in the
> > long run, so you could just remove the #ifdef and the of_match_ptr()
> > wrapper.
> >
> Only if "depends on OF" is added to its Kconfig entry, or am I missing
> something ?
>

I'm pretty sure you don't need that, it will still compile and link
fine, the only downside being a few wasted bytes to store the compatible
string and the array.

Arnd