From: Rusty Russell <rusty@rustcorp.com.au>
To: Zachary Amsden <zach@vmware.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@xensource.com>,
Chris Wright <chrisw@sous-sol.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
Adrian Bunk <bunk@stusta.de>
Subject: Re: [patch] paravirt: isolate module ops
Date: Sun, 07 Jan 2007 12:09:56 +1100 [thread overview]
Message-ID: <1168132196.20372.45.camel@localhost.localdomain> (raw)
In-Reply-To: <45A00CB0.2020509@vmware.com>
On Sat, 2007-01-06 at 12:55 -0800, Zachary Amsden wrote:
> Rusty Russell wrote:
> >
> > +int paravirt_write_msr(unsigned int msr, u64 val);
>
> If binary modules using debug registers makes us nervous, the
> reprogramming MSRs is also similarly bad.
Yes, but this is simply from experience. Several modules wrote msrs
(you can take out the EXPORT_SYMBOL and find them quite quickly).
> > +void raw_safe_halt(void);
> > +void halt(void);
>
> These shouldn't be done by modules, ever. Only the scheduler should
> decide to halt.
Several modules implement alternate halt loops. I guess being in a
module for specific CPUs makes sense...
Cheers!
Rusty.
next prev parent reply other threads:[~2007-01-07 1:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 0:07 [patch] paravirt: isolate module ops Ingo Molnar
2007-01-06 0:31 ` Zachary Amsden
2007-01-06 6:25 ` Rusty Russell
2007-01-06 7:08 ` Ingo Molnar
2007-01-06 7:12 ` Ingo Molnar
2007-01-06 17:42 ` Rusty Russell
2007-01-06 18:32 ` Ingo Molnar
2007-01-06 20:55 ` Zachary Amsden
2007-01-07 1:09 ` Rusty Russell [this message]
2007-01-07 14:07 ` Zachary Amsden
2007-01-06 7:14 ` Ingo Molnar
2007-01-06 9:50 ` Zachary Amsden
2007-01-06 10:52 ` Arjan van de Ven
2007-01-06 16:18 ` Rusty Russell
2007-01-06 19:31 ` Christoph Hellwig
2007-01-07 5:35 ` Rusty Russell
2007-01-07 18:39 ` Christoph Hellwig
2007-01-07 18:43 ` Ingo Molnar
2007-01-08 0:54 ` Dave Airlie
2007-01-06 1:02 ` Zachary Amsden
2007-01-06 2:07 ` Arjan van de Ven
2007-01-06 4:41 ` Zachary Amsden
2007-01-06 5:34 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168132196.20372.45.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=chrisw@sous-sol.org \
--cc=jeremy@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox