From: Andrei Popa <andrei.popa@i-neo.ro>
To: Frederik Deweerdt <deweerdt@free.fr>
Cc: linux-kernel@vger.kernel.org, nigel@suspend2.net
Subject: Re: [BUG] eth0 appers many times in /proc/interrupts after resume
Date: Tue, 23 Jan 2007 11:12:49 +0200 [thread overview]
Message-ID: <1169543569.10364.2.camel@localhost> (raw)
In-Reply-To: <20070121212209.GB8958@slug>
It's ok, after 4 suspend/resume cycles, eth0 only appers one time.
On Sun, 2007-01-21 at 21:22 +0000, Frederik Deweerdt wrote:
> On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote:
> > It's the 10th resume and in /proc/interrupts eth0 appers 10 times.
> >
> Hi,
>
> The e100_resume() function should be calling netif_device_detach and
> free_irq. Could you try the following (compile tested) patch?
>
> Regards,
> Frederik
>
> Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
>
> diff --git a/drivers/net/e100.c b/drivers/net/e100.c
> index 2fe0445..0c376e4 100644
> --- a/drivers/net/e100.c
> +++ b/drivers/net/e100.c
> @@ -2671,6 +2671,7 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
> del_timer_sync(&nic->watchdog);
> netif_carrier_off(nic->netdev);
>
> + netif_device_detach(netdev);
> pci_save_state(pdev);
>
> if ((nic->flags & wol_magic) | e100_asf(nic)) {
> @@ -2682,6 +2683,7 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
> }
>
> pci_disable_device(pdev);
> + free_irq(pdev->irq, netdev);
> pci_set_power_state(pdev, PCI_D3hot);
>
> return 0;
prev parent reply other threads:[~2007-01-23 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1167478664.8521.2.camel@localhost>
[not found] ` <1167479650.3337.18.camel@nigel.suspend2.net>
[not found] ` <1167480259.8855.3.camel@localhost>
[not found] ` <1167514357.2566.0.camel@nigel.suspend2.net>
[not found] ` <1167515552.30176.4.camel@localhost>
[not found] ` <1167517817.2566.13.camel@nigel.suspend2.net>
[not found] ` <1167518608.7177.0.camel@localhost>
[not found] ` <1167520557.2566.23.camel@nigel.suspend2.net>
[not found] ` <1167571281.7175.1.camel@localhost>
[not found] ` <1167599458.2662.8.camel@nigel.suspend2.net>
[not found] ` <1167605481.12328.0.camel@localhost>
[not found] ` <1167607994.2662.39.camel@nigel.suspend2.net>
[not found] ` <1167644970.7142.6.camel@localhost>
[not found] ` <1168317278.6948.9.camel@nigel.suspend2.net>
[not found] ` <1168448689.7430.1.camel@localhost>
[not found] ` <1168463852.3205.1.camel@nigel.suspend2.net>
2007-01-21 19:17 ` [BUG] eth0 appers many times in /proc/interrupts after resume Andrei Popa
2007-01-21 21:22 ` Frederik Deweerdt
2007-01-21 21:45 ` [BUG] e100: " Auke Kok
2007-01-21 22:04 ` Frederik Deweerdt
2007-01-23 0:15 ` Auke Kok
2007-01-23 9:12 ` Andrei Popa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169543569.10364.2.camel@localhost \
--to=andrei.popa@i-neo.ro \
--cc=deweerdt@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@suspend2.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox