Re: [PATCH v5 2/3] arm64: dts: ti: k3-am62l: add initial infrastructure

Bryan Brattlof
2025-05-08T13:12:32Z

On May 8, 2025 thus sayeth Nishanth Menon:
> On 08:56-20250508, Krzysztof Kozlowski wrote:
> > On 08/05/2025 08:52, Krzysztof Kozlowski wrote:
> > > On Wed, May 07, 2025 at 10:09:20PM GMT, Bryan Brattlof wrote:
> > >> +
> > >> + uart6: serial@2860000 {
> > >> + compatible = "ti,am64-uart", "ti,am654-uart";
> > >> + reg = <0x00 0x02860000 0x00 0x100>;
> > >> + interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> > >> + power-domains = <&scmi_pds 82>;
> > >> + clocks = <&scmi_clk 322>;
> > >> + clock-names = "fclk";
> > >> + status = "disabled";
> > >> + };
> > >> +
> > >> + conf: syscon@9000000 {
> > >> + compatible = "syscon", "simple-mfd";
> > >
> > > Not much improved here. You cannot have such compatibles alone and the
> > > bindings test this.
> > >
> > > Are you sure you tested this?
> > I now tested it and I am 100% sure you did not.
> >
> > Use tools and computers instead of humans for finding trivial issues.
> > This is not really acceptable.
>
> Agree.
>
> Bryan,
> In addition to bisect fails in this series, I see the following
> dtbs_check errors:
>
> arch/arm64/boot/dts/ti/k3-am62l3-evm.dtb: serial@0: clock-names:0: 'fclk' was expected
> arch/arm64/boot/dts/ti/k3-am62l3-evm.dtb: spi@fc40000: '#address-cells' is a dependency of '#size-cells'
> arch/arm64/boot/dts/ti/k3-am62l3-evm.dtb: syscon@43000000: compatible: ['syscon', 'simple-mfd'] is too short
> arch/arm64/boot/dts/ti/k3-am62l3-evm.dtb: syscon@9000000: 'reg' is a required property
>
> I suggest doing a revisit of this for the next window.
>
> PS: https://github.com/nmenon/kernel_patch_verify is a tool I use and
> maintain which might help alleviate some of the easy checklist items -
> but this is probably not an authoritative tool and making sure, but if
> it helps you, please do use it - it is containerized for easy env setup
> (you could run kpv -V -C -L -3 for example on this series and get this:
> https://gist.github.com/nmenon/83f7e6924539d1c7e2eb6c5a4ee82706 )

Yeah I apologize everyone. I was working at little late and didn't
notice my tooling to catch this stuff failed on me :/

I'll try again for the next window

Thanks for the reviews
~Bryan