From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbcGVQUf (ORCPT ); Fri, 22 Jul 2016 12:20:35 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:42487 "EHLO mx5-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbcGVQUe (ORCPT ); Fri, 22 Jul 2016 12:20:34 -0400 Date: Fri, 22 Jul 2016 12:20:27 -0400 (EDT) From: Paolo Bonzini To: Bandan Das Cc: Dave Jones , Linux Kernel , Radim =?utf-8?B?S3LEjW3DocWZ?= , kvm@vger.kernel.org Message-ID: <1171934212.9737926.1469204427109.JavaMail.zimbra@redhat.com> In-Reply-To: References: <20160715192729.GA4712@fb.com> <110045299.8101686.1468855610053.JavaMail.zimbra@redhat.com> <20160719195856.GA31453@fb.com> <20160721202440.GA10908@fb.com> <844431780.9635789.1469177321917.JavaMail.zimbra@redhat.com> Subject: Re: RFC: silencing kvm unimplemented msr spew. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.164.1, 10.5.100.50] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF47 (Linux)/8.0.6_GA_5922) Thread-Topic: silencing kvm unimplemented msr spew. Thread-Index: +OmklSSNUe4qam4ZWwmkUOJiwUUcoA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> Paolo, would you prefer this, or the other approach you already ack'd ? > > > > I think I prefer the other, because vcpu_debug is not ratelimited. > > If the guest can trigger a printk it should always be ratelimited. > > Agree with rate limiting, but making this the default for everything doesn't > sound right IMO, especially for ignore_msrs=1. vcpu_unimpl is already rate > limited. The problem is that your patch removes rate limiting whenever it now uses vcpu_debug. Paolo