public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 3/9] sysfs: move struct sysfs_dirent to private header
Date: Fri, 23 Feb 2007 15:15:50 -0800	[thread overview]
Message-ID: <11722725623183-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <11722725592291-git-send-email-gregkh@suse.de>

From: Adam J. Richter <adam@yggdrasil.com>

struct sysfs_dirent is private to the fs/sysfs/ subtree.  It is
not even referenced as an opaque structure outside of that subtree.

The following patch moves the declaration from include/linux/sysfs.h to
fs/sysfs/sysfs.h, making it clearer that nothing else in the kernel
dereferences it.

I have been running this patch for years.  Please integrate and forward
upstream if there are no objections.

From: "Adam J. Richter" <adam@yggdrasil.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 fs/sysfs/sysfs.h      |   11 +++++++++++
 include/linux/sysfs.h |   13 +------------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h
index d976b00..a77c57e 100644
--- a/fs/sysfs/sysfs.h
+++ b/fs/sysfs/sysfs.h
@@ -1,3 +1,14 @@
+struct sysfs_dirent {
+	atomic_t		s_count;
+	struct list_head	s_sibling;
+	struct list_head	s_children;
+	void 			* s_element;
+	int			s_type;
+	umode_t			s_mode;
+	struct dentry		* s_dentry;
+	struct iattr		* s_iattr;
+	atomic_t		s_event;
+};
 
 extern struct vfsmount * sysfs_mount;
 extern struct kmem_cache *sysfs_dir_cachep;
diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 192de3a..f07065c 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -17,6 +17,7 @@
 struct kobject;
 struct module;
 struct nameidata;
+struct dentry;
 
 struct attribute {
 	const char		* name;
@@ -68,18 +69,6 @@ struct sysfs_ops {
 	ssize_t	(*store)(struct kobject *,struct attribute *,const char *, size_t);
 };
 
-struct sysfs_dirent {
-	atomic_t		s_count;
-	struct list_head	s_sibling;
-	struct list_head	s_children;
-	void 			* s_element;
-	int			s_type;
-	umode_t			s_mode;
-	struct dentry		* s_dentry;
-	struct iattr		* s_iattr;
-	atomic_t		s_event;
-};
-
 #define SYSFS_ROOT		0x0001
 #define SYSFS_DIR		0x0002
 #define SYSFS_KOBJ_ATTR 	0x0004
-- 
1.5.0.1


  reply	other threads:[~2007-02-23 23:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-23 23:14 [GIT PATCH] Driver core patches for 2.6.21-rc1 Greg KH
2007-02-23 23:15 ` [PATCH 1/9] Driver core: remove class_device_rename Greg Kroah-Hartman
2007-02-23 23:15   ` [PATCH 2/9] driver core: refcounting fix Greg Kroah-Hartman
2007-02-23 23:15     ` Greg Kroah-Hartman [this message]
2007-02-23 23:15       ` [PATCH 4/9] Driver core: more fallout from class_device changes for pcmcia Greg Kroah-Hartman
2007-02-23 23:15         ` [PATCH 5/9] power management: no valid states w/o pm_ops Greg Kroah-Hartman
2007-02-23 23:15           ` [PATCH 6/9] power management: fix struct layout and docs Greg Kroah-Hartman
2007-02-23 23:15             ` [PATCH 7/9] make kernel/kmod.c:kmod_mk static Greg Kroah-Hartman
2007-02-23 23:15               ` [PATCH 8/9] Driver core: fix error by cleanup up symlinks properly Greg Kroah-Hartman
2007-02-23 23:15                 ` [PATCH 9/9] Revert "Driver core: let request_module() send a /sys/modules/kmod/-uevent" Greg Kroah-Hartman
2007-03-10 13:11                 ` [PATCH 8/9] Driver core: fix error by cleanup up symlinks properly Dmitriy Monakhov
2007-03-11 12:36                   ` [PATCH] driver core: fix device_add error path Dmitriy Monakhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11722725623183-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox