From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755396Ab1JKTcA (ORCPT ); Tue, 11 Oct 2011 15:32:00 -0400 Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:7970 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754948Ab1JKTb6 (ORCPT ); Tue, 11 Oct 2011 15:31:58 -0400 Date: Tue, 11 Oct 2011 12:31:57 -0700 (PDT) From: Andrei Warkentin To: Randy Dunlap , Namjae Jeon Cc: linux-next@vger.kernel.org, LKML , linux-mmc@vger.kernel.org, Chris Ball , Stephen Rothwell Message-ID: <1172297901.46681.1318361517579.JavaMail.root@zimbra-prod-mbox-2.vmware.com> In-Reply-To: <4E948FC3.2080801@xenotime.net> Subject: Re: mmc core broken dependency on CONFIG_BLOCK (Was: linux-next: Tree for Oct 11 (mmc)) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.113.61.163] X-Mailer: Zimbra 7.1.1_GA_3225 (ZimbraWebClient - FF3.0 (Linux)/7.1.1_GA_3225) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, ----- Original Message ----- > From: "Randy Dunlap" > To: "Stephen Rothwell" > Cc: linux-next@vger.kernel.org, "LKML" , linux-mmc@vger.kernel.org, "Chris Ball" > > Sent: Tuesday, October 11, 2011 2:49:39 PM > Subject: Re: linux-next: Tree for Oct 11 (mmc) > > On 10/11/11 02:11, Stephen Rothwell wrote: > > Hi all, > > > > The linux-next tree is now available from > > git://github.com/sfrothwell/linux-next.git as a temporary measure > > while > > the kernel.org servers are unavailable. > > > > It may also turn up on git.kernel.org (depending on the mirroring). > > The > > patch set is still absent, however. > > > > Changes since 20111007: > > > When CONFIG_BLOCK is not enabled: > > In file included from > next-2011-1011/drivers/mmc/card/sdio_uart.c:43:0: > next-2011-1011/include/linux/mmc/card.h:175:12: error: > 'DISK_NAME_LEN' undeclared here (not in a function) > > Deleting the #include fixes the sdio_uart.c build. > However, the same problem occurs in mmc/core/core.c: > Because linux/genhd is now included, oops. I'm pretty positive this is due to the "mmc : general purpose partition support" patch pulled recently. I am adding NamJae, who was the author. > In file included from next-2011-1011/drivers/mmc/core/core.c:30:0: > next-2011-1011/include/linux/mmc/card.h:175:12: error: > 'DISK_NAME_LEN' undeclared here (not in a function) > > Should mmc/core/ depend on BLOCK? or should it just be made > to build even when BLOCK is not enabled? > I don't think there should be a direct dependency on BLOCK. I have two suggestions - 1) Have our own define similar to (and in fact smaller): linux/genhd.h:#define DISK_NAME_LEN 32 2) Put the MMC physical partition code under an #ifdef CONFIG_BLOCK, which is a reasonable proposition, given that there wouldn't be any need to parse physical partition info if it would never be consumed by the MMC block driver. Thoughts? A