From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbXB0O53 (ORCPT ); Tue, 27 Feb 2007 09:57:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752493AbXB0O53 (ORCPT ); Tue, 27 Feb 2007 09:57:29 -0500 Received: from rrcs-24-153-217-226.sw.biz.rr.com ([24.153.217.226]:60069 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485AbXB0O52 (ORCPT ); Tue, 27 Feb 2007 09:57:28 -0500 Subject: Re: [PATCH 7/7] cxgb3 - Add SW LRO support From: Steve Wise To: Jeff Garzik Cc: Christoph Hellwig , divy@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <45E445D2.2090900@garzik.org> References: <20070225004423.20903.17036.stgit@localhost.localdomain> <20070226051304.GA13626@infradead.org> <1172585835.11870.13.camel@stevo-desktop> <45E445D2.2090900@garzik.org> Content-Type: text/plain Date: Tue, 27 Feb 2007 08:57:26 -0600 Message-Id: <1172588246.11870.24.camel@stevo-desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.4.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2007-02-27 at 09:53 -0500, Jeff Garzik wrote: > Steve Wise wrote: > > On Mon, 2007-02-26 at 05:13 +0000, Christoph Hellwig wrote: > >> On Sat, Feb 24, 2007 at 04:44:23PM -0800, divy@chelsio.com wrote: > >>> From: Divy Le Ray > >>> > >>> Add all-in-sw lro support. > >> Doing this in a LLDD doesn't sound like a good idea. Have you > >> tried doing this in the core networking code instead? > > > > It looks like both Netxen and Neterion drivers already have this. So I > > think for now the LLDD implements LRO. The stack supports it by virtue > > That's argument to further avoiding compounding the problem, by > reinventing the wheel for each driver. You're right. But cxgb3 has it now in the driver (tested and working). Shouldn't it be pulled in? When the network stack design gets done (which could take a few releases to finalize), all the drivers can be updated to use it. It doesn't seem reasonable to allow some drivers to support LRO and others to not support it... Steve.