From: "Wu, Bryan" <bryan.wu@analog.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: bryan.wu@analog.com, nico@cam.org, jgarzik@pobox.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver
Date: Thu, 01 Mar 2007 17:52:48 +0800 [thread overview]
Message-ID: <1172742768.5264.97.camel@roc-desktop> (raw)
In-Reply-To: <20070301013201.e43ae3f5.akpm@linux-foundation.org>
On Thu, 2007-03-01 at 01:32 -0800, Andrew Morton wrote:
> On Thu, 01 Mar 2007 17:23:23 +0800 "Wu, Bryan" <bryan.wu@analog.com> wrote:
>
> > On Thu, 2007-03-01 at 00:54 -0800, Andrew Morton wrote:
> > > On Thu, 01 Mar 2007 12:15:29 +0800 "Wu, Bryan" <bryan.wu@analog.com> wrote:
> > >
> > > > +/* check if the mac in reg is valid */
> > > > +#define SMC_GET_MAC_ADDR(addr) \
> > > > + do { \
> > > > + unsigned int __v; \
> > > > + __v = SMC_inw( ioaddr, ADDR0_REG ); \
> > > > + addr[0] = __v; addr[1] = __v >> 8; \
> > > > + __v = SMC_inw( ioaddr, ADDR1_REG ); \
> > > > + addr[2] = __v; addr[3] = __v >> 8; \
> > > > + __v = SMC_inw( ioaddr, ADDR2_REG ); \
> > > > + addr[4] = __v; addr[5] = __v >> 8; \
> > > > + if (*(u32 *)(&addr[0]) == 0xFFFFFFFF) { \
> > > > + random_ether_addr(addr); \
> > > > + } \
> > > > + } while (0)
> > >
> > > Please follow kernel coding style:
> > >
> > > __v = SMC_inw(ioaddr, ADDR2_REG);
> > >
>
> You skipped this:
>
> > > Can this not be implemented as a C function?
>
> > +#define SMC_GET_MAC_ADDR(addr) \
> > + do { \
> > + unsigned int __v; \
> > + __v = SMC_inw(ioaddr, ADDR0_REG); \
> > + addr[0] = __v; addr[1] = __v >> 8; \
> > + __v = SMC_inw(ioaddr, ADDR1_REG); \
> > + addr[2] = __v; addr[3] = __v >> 8; \
> > + __v = SMC_inw(ioaddr, ADDR2_REG); \
> > + addr[4] = __v; addr[5] = __v >> 8; \
> > + if (*(u32 *)(&addr[0]) == 0xFFFFFFFF) { \
> > + random_ether_addr(addr); \
> > + } \
> > + } while (0)
>
> It can be, I think...
>
> Please always prefer coding in C over coding in cpp.
Yes, it can be writen as a C function.
We just follow other implementation in the drivers/net/smc91x.h
start at line 1156 of
---
#ifndef SMC_GET_MAC_ADDR
#define SMC_GET_MAC_ADDR(addr) \
do { \
unsigned int __v; \
__v = SMC_inw( ioaddr, ADDR0_REG ); \
addr[0] = __v; addr[1] = __v >> 8; \
__v = SMC_inw( ioaddr, ADDR1_REG ); \
addr[2] = __v; addr[3] = __v >> 8; \
__v = SMC_inw( ioaddr, ADDR2_REG ); \
addr[4] = __v; addr[5] = __v >> 8; \
} while (0)
#endif
_
If you think this is necessary, we may rewrite it in C function.
Thanks
-Bryan
next prev parent reply other threads:[~2007-03-01 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 4:15 [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver Wu, Bryan
2007-03-01 8:54 ` Andrew Morton
2007-03-01 9:23 ` Wu, Bryan
2007-03-01 9:32 ` Andrew Morton
2007-03-01 9:52 ` Wu, Bryan [this message]
2007-03-01 10:03 ` Andrew Morton
2007-03-01 10:16 ` Wu, Bryan
2007-03-01 9:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172742768.5264.97.camel@roc-desktop \
--to=bryan.wu@analog.com \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox