The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Wu, Bryan" <bryan.wu@analog.com>
To: linux-kernel@vger.kernel.org
Subject: Questions about the SYSVIPC share memory on NOMMU uClinux architecture
Date: Fri, 02 Mar 2007 18:33:49 +0800	[thread overview]
Message-ID: <1172831630.5264.139.camel@roc-desktop> (raw)

Hi folks,

Recently, I was struggling in a bug about the shm->nattch. Actually, the
test case is from LTP kernel/syscall/ipc/shmctl/shmctl01.c code. We
ported it to the uClinux-blackfin platform.

The algorithm is very simple. 
a) the parent process will create a share memory 
b) parent will vfork/execlp 4 children process
c) children will call shmat() attach to the share memory (shm->nattch
should be increased), then children will pause()
d) parent call shmclt() to get the share memory nattch, if nattch != 4,
then the testcase will fail.

In our uClinux-blackfin platform, nattch = 1.

So I dig into the source code ipc/shm.c, then there are some questions
about the code.

a)
in function do_shmat(), after nattch++ why nattch-- as following:
================================================================================
 user_addr = (void*) do_mmap (file, addr, size, prot, flags, 0);

	// here no return or goto valid place.

invalid:
        up_write(&current->mm->mmap_sem);

        mutex_lock(&shm_ids(ns).mutex);
        shp = shm_lock(ns, shmid);
        BUG_ON(!shp);
        shp->shm_nattch--; /* Why??? */
        if(shp->shm_nattch == 0 &&
           shp->shm_perm.mode & SHM_DEST)
                shm_destroy(ns, shp);
        else
                shm_unlock(shp);
        mutex_unlock(&shm_ids(ns).mutex);

        *raddr = (unsigned long) user_addr;
        err = 0;
        if (IS_ERR(user_addr))
                err = PTR_ERR(user_addr);
out:
        return err;
================================================================================

b) do_mmap() -> mm/nommu.c do_mmap_pgoff()
When create a new vma structure, shm_open(), shm_inc() will be called. Then nattch++.
So the nattch counting is disordered.

Please give me some hint about it. Actually, this case can pass on X86 platform

Thanks
-Bryan Wu

             reply	other threads:[~2007-03-02 10:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-02 10:33 Wu, Bryan [this message]
2007-03-05  1:40 ` Questions about the SYSVIPC share memory on NOMMU uClinuxarchitecture Wu, Bryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1172831630.5264.139.camel@roc-desktop \
    --to=bryan.wu@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox