From: john stultz <johnstul@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
andreas.friedrich@fujitsu-siemens.com,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Walker <dwalker@mvista.com>
Subject: Re: [PATCH -mm] clocksource init adjustments (fix bug #7426)
Date: Fri, 02 Mar 2007 11:58:11 -0800 [thread overview]
Message-ID: <1172865491.5449.13.camel@localhost.localdomain> (raw)
In-Reply-To: <20070302021827.7edc1a23.akpm@linux-foundation.org>
On Fri, 2007-03-02 at 02:18 -0800, Andrew Morton wrote:
> On Thu, 22 Feb 2007 16:13:02 -0800 john stultz <johnstul@us.ibm.com> wrote:
> > Thus the solution here is to register clocksources earlier (ideally when
> > the hardware is being initialized), and then we enable clocksource
> > selection at fs_initcall (before device_initcall).
> >
> > This patch should probably get some testing time in -mm, since
> > clocksource selection is one of the most important issues for correct
> > timekeeping, and I've only been able to test this on a few of my own
> > boxes.
>
> This doornails my Nocona box early in boot:
> http://userweb.kernel.org/~akpm/s5000431.jpg
>
> Slab isn't ready yet - time_init()->hpet_arch_init() is called before
> start_kernel() has run kmem_cache_init().
Oh! Sorry! Yea, looking at it more the ioremap isn't actually necessary,
as we can use hpet_readl() instead of re-calculating the hpet base
address pointer.
I'll fix this up (and find an HPET enabled x86_64 box to test it on) and
get a patch to you shortly.
Sorry again!
-john
next prev parent reply other threads:[~2007-03-02 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-23 0:13 [PATCH -mm] clocksource init adjustments (fix bug #7426) john stultz
2007-03-02 10:18 ` Andrew Morton
2007-03-02 19:58 ` john stultz [this message]
2007-03-02 20:32 ` David Miller
2007-03-02 23:24 ` [PATCH -mm][Take 2] " john stultz
2007-03-02 23:30 ` David Miller
2007-03-04 16:25 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172865491.5449.13.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andreas.friedrich@fujitsu-siemens.com \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox