From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030241AbXCCN13 (ORCPT ); Sat, 3 Mar 2007 08:27:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030242AbXCCN13 (ORCPT ); Sat, 3 Mar 2007 08:27:29 -0500 Received: from email.authentidate.de ([213.61.157.66]:53975 "EHLO email.authentidate.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030241AbXCCN12 convert rfc822-to-8bit (ORCPT ); Sat, 3 Mar 2007 08:27:28 -0500 Subject: Re: usbserial not working/oops on removal From: Andreas Laumann To: Oliver Neukum Cc: Kevin Fenzi , linux-kernel@vger.kernel.org In-Reply-To: <200703031138.20582.oliver@neukum.org> References: <20070302193715.568098a6@ningauble.scrye.com> <200703030745.19547.oliver@neukum.org> <1172906384.26337.13.camel@justine.inexnet.de> <200703031138.20582.oliver@neukum.org> Content-Type: text/plain; charset=UTF-8 Organization: AuthentiDate International AG Date: Sat, 03 Mar 2007 14:27:21 +0100 Message-Id: <1172928441.3710.8.camel@justine.inexnet.de> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-1.fc6) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Am Samstag, den 03.03.2007, 11:38 +0100 schrieb Oliver Neukum: > Am Samstag, 3. März 2007 08:19 schrieb Andreas Laumann: > > Am Samstag, den 03.03.2007, 07:45 +0100 schrieb Oliver Neukum: > > > Am Samstag, 3. März 2007 03:37 schrieb Kevin Fenzi: > > > > I'm seeing some oddity with the latest fedora development kernel and a > > > > usbserial device. > > > > > > Very interesting. Is this repeatable? Does unplugging have the same effect? > > > > I see it also on fedora rawhide using reinersct (cyberjack) scard > > readers and it repeatable. > > The first usbserial devices likes to register the line number 255 which > > indeed is invalid. > > OK, please try this patch. > > Regards > Oliver > > --- linux-2.6.21-rc1/drivers/usb/serial/usb-serial.c.alt 2007-02-21 05:32:30.000000000 +0100 > +++ linux-2.6.21-rc1/drivers/usb/serial/usb-serial.c 2007-02-26 15:32:50.000000000 +0100 > @@ -826,7 +826,6 @@ > num_ports = type->num_ports; > } > > - serial->minor = minor; > serial->num_ports = num_ports; > serial->num_bulk_in = num_bulk_in; > serial->num_bulk_out = num_bulk_out; > @@ -980,6 +979,7 @@ > dev_err(&interface->dev, "No more free serial devices\n"); > goto probe_error; > } > + serial->minor = minor; > > /* register all of the individual ports with the driver core */ > for (i = 0; i < num_ports; ++i) { Unfortunately your fix does not work. The first one seems registered correctly, but after that it fails again for the next one. usbcore: registered new interface driver usbserial drivers/usb/serial/usb-serial.c: USB Serial support registered for generic usbcore: registered new interface driver usbserial_generic drivers/usb/serial/usb-serial.c: USB Serial Driver core drivers/usb/serial/usb-serial.c: USB Serial support registered for Reiner SCT Cyberjack USB card reader cyberjack 5-2.2:1.0: Reiner SCT Cyberjack USB card reader converter detected usb 5-2.2: Reiner SCT Cyberjack USB card reader converter now attached to ttyUSB0 cyberjack 5-2.3:1.0: Reiner SCT Cyberjack USB card reader converter detected usb-serial ttyUSB0: Error registering port device, continuing usbcore: registered new interface driver cyberjack drivers/usb/serial/cyberjack.c: v1.01 Matthias Bruestle drivers/usb/serial/cyberjack.c: REINER SCT cyberJack pinpad/e-com USB Chipcard Reader Driver Andreas