From: Eric Paris <eparis@parisplace.org>
To: James Morris <jmorris@namei.org>
Cc: Venkat Yekkirala <vyekkirala@TrustedCS.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Venkat Yekkirala <vyekkirala@tcsfw4.tcs-sec.com>,
cxzhang@watson.ibm.com, Stephen Smalley <sds@tycho.nsa.gov>
Subject: RE: [PATCH] xfrm_policy delete security check misplaced
Date: Mon, 05 Mar 2007 11:51:28 -0500 [thread overview]
Message-ID: <1173113488.31047.36.camel@localhost.localdomain> (raw)
In-Reply-To: <Line.LNX.4.64.0703051139040.14821@d.namei>
On Mon, 2007-03-05 at 11:39 -0500, James Morris wrote:
> On Mon, 5 Mar 2007, Venkat Yekkirala wrote:
>
> > >
> > > Signed-off-by: Eric Paris <eparis@redhat.com>
> > Acked-by: Venkat Yekkirala <vyekkirala@trustedcs.com>
>
> What about your previous comment:
>
> "I guess you meant to do this here?
> else if (err)
> return err; "
That also gets taken care of in the pfkey_spdget cleanup in a later
patch. The return isn't in that same place venkat suggested it instead
happens inside the new if (delete) block. (err is only non-zero on
delete operations so there is no need to check it otherwise)
-Eric
next prev parent reply other threads:[~2007-03-05 21:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 18:29 [PATCH] xfrm_policy delete security check misplaced Eric Paris
2007-03-05 15:33 ` Venkat Yekkirala
2007-03-05 15:58 ` Venkat Yekkirala
2007-03-05 16:39 ` James Morris
2007-03-05 16:51 ` Eric Paris [this message]
2007-03-05 17:10 ` Venkat Yekkirala
2007-03-06 0:37 ` James Morris
2007-03-07 23:38 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-03-05 15:36 Venkat Yekkirala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173113488.31047.36.camel@localhost.localdomain \
--to=eparis@parisplace.org \
--cc=cxzhang@watson.ibm.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=vyekkirala@TrustedCS.com \
--cc=vyekkirala@tcsfw4.tcs-sec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox