From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [S390] system call cleanup.
Date: Tue, 06 Mar 2007 10:21:16 +0100 [thread overview]
Message-ID: <1173172876.24596.0.camel@localhost> (raw)
In-Reply-To: <20070306072706.GA22458@infradead.org>
On Tue, 2007-03-06 at 07:27 +0000, Christoph Hellwig wrote:
> > + struct pt_regs *regs = task_pt_regs(current);
> > + char *filename;
> > + unsigned long result;
> > + int rc;
> > +
> > + filename = getname(compat_ptr(regs->orig_gpr2));
> > + if (IS_ERR(filename)) {
> > + result = PTR_ERR(filename);
> > goto out;
>
> The old code here..
>
> > + struct pt_regs *regs = task_pt_regs(current);
> > unsigned long clone_flags;
> > unsigned long newsp;
> > int __user *parent_tidptr, *child_tidptr;
>
> ..and here..
>
> > +asmlinkage long sys_clone(void)
> > {
> > + struct pt_regs *regs = task_pt_regs(current);
> > unsigned long clone_flags;
> > unsigned long newsp;
> > int __user *parent_tidptr, *child_tidptr;
>
> ..and here used spaces instead of tabs, it would be nice to clean this
> up while you're at it.
Will do, thanks for the hint.
--
blue skies, IBM Deutschland Entwicklung GmbH
Martin Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Martin Schwidefsky Sitz der Gesellschaft: Böblingen
Linux on zSeries Registergericht: Amtsgericht Stuttgart,
Development HRB 243294
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2007-03-06 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 22:43 [S390] system call cleanup Martin Schwidefsky
2007-03-06 7:27 ` Christoph Hellwig
2007-03-06 9:21 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173172876.24596.0.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox