From: "Wu, Bryan" <bryan.wu@analog.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jean Delvare <khali@linux-fr.org>, Bryan Wu <bryan.wu@analog.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Sonic Zhang <sonic.adi@gmail.com>,
Mike Frysinger <vapier.adi@gmail.com>,
linux-kernel@vger.kernel.org, mhfan@ustc.edu
Subject: Re: [PATCH -mm] Blackfin: blackfin i2c driver
Date: Wed, 07 Mar 2007 15:39:27 +0800 [thread overview]
Message-ID: <1173253167.28531.41.camel@roc-desktop> (raw)
In-Reply-To: <20070306231423.4231c99b.akpm@linux-foundation.org>
On Tue, 2007-03-06 at 23:14 -0800, Andrew Morton wrote:
> On Wed, 7 Mar 2007 07:58:22 +0100 Jean Delvare <khali@linux-fr.org> wrote:
>
> > > +config BFIN_SDA
> >
> > I2C_BLACKFIN_SDA
>
> The blackfin architecture uses "bfin" pretty much universally, so this
> usage is consistent.
>
> box:/usr/src/25> grep -i blackfin patches/blackfin*|wc -l
> 1608
> box:/usr/src/25> grep -i bfin patches/blackfin*|wc -l
> 6198
>
Thanks for you understanding, but now we want to move to use
CONFIG_BLACKFIN options. There is a new task in our development plan to
change things to CONFIG_BLACKFIN.
At this moment, we both provide CONFIG_BFIN and CONFIG_BLACKFIN. When
all the things relied on CONFIG_BFIN/bfin are changed to
CONFIG_BLACKFIN/blackfin, the CONFIG_BFIN will be removed.
So here I will follow Jean's comments.
> Let's just hope nobody makes a bluefin.
So it is ok for both blackfin and bluefin. But I think Black is cooler
than Blue. -:)
>
> > > + range 0 15 if (BF533 || BF532 || BF531)
> >
> > Trailing whitespace.
>
> I always remove that when merging a patch.
Thanks a lot, could you please give me a script just to kill this
whitespace? So I can do it before sending you patches.
Thanks Jean and Andrew.
-Bryan
next prev parent reply other threads:[~2007-03-07 7:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 6:54 [PATCH -mm] Blackfin: blackfin i2c driver Wu, Bryan
2007-03-06 7:18 ` Andrew Morton
2007-03-07 5:17 ` Sonic Zhang
2007-03-07 6:06 ` Andrew Morton
2007-03-07 6:38 ` Wu, Bryan
2007-03-06 21:43 ` Alexey Dobriyan
2007-03-06 23:04 ` Mike Frysinger
2007-03-07 5:57 ` Wu, Bryan
2007-03-07 6:58 ` Jean Delvare
2007-03-07 7:14 ` Andrew Morton
2007-03-07 7:39 ` Wu, Bryan [this message]
2007-03-07 7:45 ` Andrew Morton
2007-03-08 3:57 ` trailing whitespace killing (Re: [PATCH -mm] Blackfin: blackfin i2c driver) Oleg Verych
2007-03-08 7:35 ` [PATCH -mm] Blackfin: blackfin i2c driver Jean Delvare
2007-03-07 9:53 ` Wu, Bryan
2007-03-08 9:27 ` Jean Delvare
2007-03-09 4:04 ` Sonic Zhang
2007-03-09 9:47 ` Jean Delvare
2007-03-07 7:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173253167.28531.41.camel@roc-desktop \
--to=bryan.wu@analog.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhfan@ustc.edu \
--cc=sonic.adi@gmail.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox