From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Johannes Stezenbach <js@linuxtv.org>
Cc: Simon Arlott <simon@fire.lp0.eu>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Oberritter <obi@linuxtv.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-dvb@linuxtv.org
Subject: Re: [PATCH] dvb-core: Fix several locking related problems.
Date: Sat, 10 Mar 2007 07:23:57 -0200 [thread overview]
Message-ID: <1173518637.9092.5.camel@localhost> (raw)
In-Reply-To: <20070310014959.GA4147@linuxtv.org>
Em Sáb, 2007-03-10 às 02:49 +0100, Johannes Stezenbach escreveu:
> On Sun, Mar 04, 2007 at 05:45:54PM +0000, Simon Arlott wrote:
> > Fix several instances of dvb-core functions using mutex_lock_interruptible
> > and returning -ERESTARTSYS where the calling function will either never
> > retry or never check the return value.
> >
> > These cause a race condition with dvb_dmxdev_filter_free and
> > dvb_dvr_release, both of which are filesystem release functions whose
> > return value is ignored and will never be retried. When this happens it
> > becomes impossible to open dvr0 again (-EBUSY) since it has not been
> > released properly.
> >
> > Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
>
> Acked-By: Johannes Stezenbach <js@linuxtv.org>
>
> I can't test this but to me it looks good.
> Mauro, could you please pick it up and keep it in the
> linuxtv.org repository for a while for testing?
Done.
Thanks, Johannes.
--
Cheers,
Mauro
prev parent reply other threads:[~2007-03-10 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <45DCB3A3.3060705@simon.arlott.org.uk>
[not found] ` <45E08886.50606@linuxtv.org>
[not found] ` <45E08BFD.3080203@simon.arlott.org.uk>
[not found] ` <45E9D923.7040707@simon.arlott.org.uk>
[not found] ` <45EAE894.1010000@linuxtv.org>
2007-03-04 17:45 ` [PATCH] dvb-core: Fix several locking related problems Simon Arlott
2007-03-10 1:49 ` Johannes Stezenbach
2007-03-10 9:23 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173518637.9092.5.camel@localhost \
--to=mchehab@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=js@linuxtv.org \
--cc=linux-dvb@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=obi@linuxtv.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox