Re: [patch 6/9] signalfd/timerfd v1 - timerfd core ...

Nicholas Miell
2007-03-11T01:49:23Z

On Sat, 2007-03-10 at 16:35 -0800, Linus Torvalds wrote:
>
> On Sat, 10 Mar 2007, Nicholas Miell wrote:
> > >
> > > I'd actually much rather do POSIX timers the other way around: associate a
> > > generic notification mechanism with the file descriptor, and then
> > > implement posix_timer_create() on top of timerfd. Now THAT sounds like a
> > > clean unix-like interface ("everything is a file") and would imply that
> > > you'd be able to do the same kind of notification for any file descriptor,
> > > not just timers.
> > >
> >
> > But timers aren't files or even remotely file-like
>
> What do you think "a file" is?
>
> In UNIX, a file descriptor is pretty much anything. You could say that
> sockets aren't remotely file-like, and you'd be right. What's your point?
> If you can read on it, it's a file.

Ah, I see. You're just interested in fds as a generic handle concept,
and not a more Plan 9 type thing.

If that's the goal, somebody should start thinking about reducing the
contents of struct file to the bare minimum (i.e. not much more than a
file_operations pointer).

>
> And the real point of the whole signalfd() is that there really *are* a
> lot of UNIX interfaces that basically only work with file descriptors. Not
> just read, but select/poll/epoll.

It'd be useful if the polling interfaces could return small datums
beyond just the POLL* flags -- having to do a read on timerfd just to
get the overrun count has a lot of overhead for just an integer, and I
imagine other things would like to pass back stuff too.

> They currently have just one timeout, but the thing is, if UNIX had just
> had "timer file descriptors", they'd not need even that one. And even with
> the timeout, Davide's patch actually makes for a *better* timeout than the
> ones provided by select/poll/epoll, exactly because you can do things like
> repeating timers and absolute time etc.
>
> Much more naturally than the timer interface we currently have for those
> system calls.
>

You still want timeouts, creating/setting/destroying at timer just for
a single call to select/poll/epoll is probably too heavy weight.

timerfd() still leaves out the basic clock selection functionality
provided by both setitimer() and timer_create().

> The same goes for signals. The whole "pselect()" thing shows that signals
> really *should* have been file descriptors, and suddenly you don't need
> "pselect()" at all.
>
> So the "not remotely file-like" is not actually a real argument. One of
> the big *points* of UNIX was that it unified a lot under the general
> umbrella of a "file descriptor". Davide just unifies even more.
>
> Linus
--
Nicholas Miell <nmiell@comcast.net>