From: Rusty Russell <rusty@rustcorp.com.au>
To: Andi Kleen <ak@muc.de>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
arjan@infradead.org
Subject: Re: CONFIG_REORDER Kconfig help strange sentence.
Date: Tue, 13 Mar 2007 17:37:35 +1100 [thread overview]
Message-ID: <1173767855.10618.46.camel@localhost.localdomain> (raw)
In-Reply-To: <20070312235605.GA14444@muc.de>
On Tue, 2007-03-13 at 00:56 +0100, Andi Kleen wrote:
> On Tue, Mar 13, 2007 at 10:18:03AM +1100, Rusty Russell wrote:
> > OK, this confused me:
> >
> > Function reordering (REORDER) [N/y/?] (NEW) ?
> >
> > This option enables the toolchain to reorder functions for a more
> > optimal TLB usage. If you have pretty much any version of binutils,
> > this can increase your kernel build time by roughly one minute.
> >
> > "If you have pretty much any version of binutils"? Huh?
> >
> > You mean "This will slow your kernel build by about a minute"?
>
> Yes. Lots of sections seem to trigger some quadratic behaviour in ld.
>
> It might be fixed in some unreleased CVS version though (not 100% sure)
>
> -Andi
OK, well here is a patch for the moment.
==
Clarify CONFIG_REORDER explanation
if (1 && X) => if (X).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r de5618b5e562 arch/x86_64/Kconfig
--- a/arch/x86_64/Kconfig Tue Mar 13 11:41:55 2007 +1100
+++ b/arch/x86_64/Kconfig Tue Mar 13 17:27:05 2007 +1100
@@ -632,8 +632,8 @@ config REORDER
default n
help
This option enables the toolchain to reorder functions for a more
- optimal TLB usage. If you have pretty much any version of binutils,
- this can increase your kernel build time by roughly one minute.
+ optimal TLB usage. This will slow your kernel build by
+ roughly one minute.
config K8_NB
def_bool y
next prev parent reply other threads:[~2007-03-13 6:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 23:18 CONFIG_REORDER Kconfig help strange sentence Rusty Russell
2007-03-12 23:56 ` Andi Kleen
2007-03-13 6:37 ` Rusty Russell [this message]
2007-03-16 1:34 ` Randy Dunlap
2007-03-17 8:54 ` Rusty Russell
2007-03-18 4:32 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173767855.10618.46.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@muc.de \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox