Re: [PATCH] FUTEX : new PRIVATE futexes

Jan Engelhardt
2007-04-06T17:59:09Z

On Apr 6 2007 07:05, Hugh Dickins wrote:
>On Fri, 6 Apr 2007, Nick Piggin wrote:
>>
>> I like |= for adding flags, it seems less ambiguous. But I guess that's
>> a matter of opinion. Hugh seems to like +=,
>
>Do I? You probably have a shaming example in mind (PAGE_MAPPING_ANON?
>that's a hybrid case where using + and - helped minimize the casting);
>but in general I'd agree with you that it's |= for setting flag bits.
>
>Hmm, Eric's FUT_OFF_INODE is hybrid too, that might justify the +=

If a bit is already set, you can't set it again using +=.

Jan
--