public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paul Mackerras <paulus@samba.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] genirq: do not mask interrupts by default
Date: Tue, 27 Mar 2007 15:18:05 +1000	[thread overview]
Message-ID: <1174972685.5329.12.camel@localhost.localdomain> (raw)
In-Reply-To: <1174972037.5329.5.camel@localhost.localdomain>


> I missed that one ... thanks for not telling/CC'ing me and not fixing
> powerpc :-( (I know, everybody is supposed to have the bandwidth to read
> all of lkml... I don't).
> 
> We need to audit all of our PICs to make sure they can deal with
> disabling an already ack'ed interrupt, which isn't clear.. in fact, that
> might cause some to lose it when re-enabling later on. This is a major
> semantic change and now I just discover it while we are at -rc5 !
> 
> I'm concerned that quite a few PICs will not re-emit the interrupt once
> re-enabled.

Note that I'm not opposed to the change at all, I think it's a good
idea, I'm just worried I'm discovering it a bit late and I've seen PICs
broken in some many colorful ways that I'm a bit worried... Oh well...

Ben.



  reply	other threads:[~2007-03-27  5:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200702161759.l1GHxsO8010669@hera.kernel.org>
2007-03-27  5:07 ` [PATCH] genirq: do not mask interrupts by default Benjamin Herrenschmidt
2007-03-27  5:18   ` Benjamin Herrenschmidt [this message]
2007-03-27  7:32     ` Ingo Molnar
2007-03-27  8:04       ` Benjamin Herrenschmidt
2007-01-30  9:33 [patch] " Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2006-11-08  2:33 Linux 2.6.19-rc5 Linus Torvalds
     [not found] ` <20061108085235.GT4729@stusta.de>
     [not found]   ` <7813413.118221162987983254.komurojun-mbn@nifty.com>
2006-11-10 12:42     ` Re: Re: 2.6.19-rc5: known regressions :SMP kernel can not generate ISA irq Komuro
2006-11-13 16:02       ` Linus Torvalds
2006-11-13 17:11         ` Eric W. Biederman
2006-11-13 20:44           ` Ingo Molnar
2006-11-13 21:11             ` Eric W. Biederman
2006-11-14  8:14               ` [patch] irq: do not mask interrupts by default Ingo Molnar
2006-11-14 16:10                 ` Linus Torvalds
     [not found]                   ` <20061115090427.GA16173@elte.hu>
2006-11-15 16:13                     ` [patch] genirq: " Linus Torvalds
2006-11-15 17:46                       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1174972685.5329.12.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox