The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Wu, Bryan" <bryan.wu@analog.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: akpm@linux-foundation.org, bryan.wu@analog.com,
	linux-kernel@vger.kernel.org, dhowells@redhat.com,
	alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] revoke: generic_file_revoke stub for NOMMU
Date: Wed, 28 Mar 2007 15:15:40 +0800	[thread overview]
Message-ID: <1175066140.15391.21.camel@roc-desktop> (raw)
In-Reply-To: <Pine.LNX.4.64.0703280923170.30354@sbz-30.cs.Helsinki.FI>

On Wed, 2007-03-28 at 09:24 +0300, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
> 
> As NOMMU does not include fs/revoke.c, we need to provide a stub for
> generic_file_revoke() so that filesystems using it compile.
> 
> Cc: Bryan Wu <bryan.wu@analog.com>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> ---
>  include/linux/fs.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> Index: uml-2.6/include/linux/fs.h
> ===================================================================
> --- uml-2.6.orig/include/linux/fs.h	2007-03-28 09:18:57.000000000 +0300
> +++ uml-2.6/include/linux/fs.h	2007-03-28 09:20:48.000000000 +0300
> @@ -1741,7 +1741,11 @@ extern long do_splice_direct(struct file
>  		size_t len, unsigned int flags);
>  
>  /* fs/revoke.c */
> +#ifdef CONFIG_MMU
>  extern int generic_file_revoke(struct file *);
> +#else
> +#define generic_file_revoke NULL
> +#endif
>  
>  extern void
>  file_ra_state_init(struct file_ra_state *ra, struct address_space *mapping);

Cool, you are so quick and your patchbomb tool is very efficient. I will
test it on my side ASAP.

Thanks
-Bryan

  reply	other threads:[~2007-03-28  7:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26 12:12 revoke: no revoke for nommu Pekka J Enberg
2007-03-26 12:25 ` David Howells
2007-03-27  3:42   ` Wu, Bryan
2007-03-28  6:09 ` Wu, Bryan
2007-03-28  6:24   ` [PATCH] revoke: generic_file_revoke stub for NOMMU Pekka J Enberg
2007-03-28  7:15     ` Wu, Bryan [this message]
2007-03-28  7:17       ` Pekka J Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175066140.15391.21.camel@roc-desktop \
    --to=bryan.wu@analog.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox