Re: [PATCH 11/16] samba-eintr-fix.diff

Andrew Morton
2007-04-02T05:53:53Z

On Sun, 1 Apr 2007 20:16:22 +0200 (MEST) Jan Engelhardt <jengelh@linux01.gwdg.de> wrote:

>
> From: Dave Jones
> Already posted at http://lkml.org/lkml/2005/7/7/255
>
> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
> Cc: Dave Jones <Dave Jones <davej@redhat.com>
>
> request.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6.21-rc5/fs/smbfs/request.c
> ===================================================================
> --- linux-2.6.21-rc5.orig/fs/smbfs/request.c
> +++ linux-2.6.21-rc5/fs/smbfs/request.c
> @@ -347,6 +347,7 @@ int smb_add_request(struct smb_request *
> smb_rput(req);
> }
> smb_unlock_server(server);
> + return -EINTR;
> }
>
> if (!timeleft) {
> #<EOF>

This can return -EINTR if timeleft == 0 && !signal_pending(), which seems
wrong.