Re: [PATCH 3/16] vt-underline-color.diff

Andrew Morton
2007-04-02T05:37:09Z

On Sun, 1 Apr 2007 20:14:14 +0200 (MEST) Jan Engelhardt <jengelh@linux01.gwdg.de> wrote:

> static u8 vgacon_build_attr(struct vc_data *c, u8 color, u8 intensity,
> - u8 blink, u8 underline, u8 reverse);
> + u8 blink, u8 underline, u8 reverse, u8);

ug. It's better to include the names of the parameters, IMO. But mixing
the two styles like this is nuts.

Happily, the declaration is unneeded anyway, so I'll just delete it.