Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

Chris Wright
2007-04-02T22:24:42Z

* Thomas Gleixner (tglx@linutronix.de) wrote:
> On Mon, 2007-04-02 at 14:39 -0700, Chris Wright wrote:
> > the part i know is broken is lapic broadcast, so i'd like to fix that
> > up too. trouble is, it's broken on vanilla too, so i'm not 100% sure
> > what i'm debugging yet.
>
> You need to remove switch_APIC_timer_to_ipi and counterpart so that the
> clockevents broadcast gets control over broadcasting. This requires a
> change in drivers/acpi/processor_idle.c as well
>
> commit e9e2cdb412412326c4827fc78ba27f410d837e6e has the basic changes.

Yeah, I saw that, and while I didn't remove it yet, it shouldn't be
getting called from anywhere because of CONFIG_GENERIC_CLOCKEVENTS
being set. In fact, acpi_propagate_timer_broadcast() does get called,
and all that does it drop me back to hpet because of C3. But, I didn't add
DUMMY yet, and I must've missed smth else. Some of that got a little
tangled into the nice calibration cleanup, which I didn't want to suck
in until I understood what I had broken ;-)

thanks,
-chris