public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Paul LeoNerd Evans <leonerd@leonerd.org.uk>
Subject: Re: [PATCH] vt: Do not clear UTF when resetting console
Date: Tue, 03 Apr 2007 08:16:17 +0800	[thread overview]
Message-ID: <1175559377.7267.13.camel@daplas> (raw)
In-Reply-To: <46113ED6.4060005@zytor.com>

On Mon, 2007-04-02 at 10:35 -0700, H. Peter Anvin wrote:
> Antonino A. Daplas wrote:
> > Resetting the console, either by ANSI escape sequences or by the reset utility,
> > will drop the console back to legacy (non-UTF-8) mode. Fix this by leaving the
> > field vc_data.vc_utf untouched in reset_terminal(). In addition, a global
> > variable (default_utf8) which defines system-wide UTF-8 setting is created.
> > This variable can be adjusted via sysfs.
> 
> If you're going to introduce a system-wide default, instead of issuing 
> the appropriate escape code, then I would argue it should still be 
> forced (to the default) when issuing a console reset.
> 

That would be the cleanest and purest behavior. But it's possible to set
one console to UTF-8 and another to legacy mode. So one can corrupt the
user's console just by issuing a reset or echo -e '\033c'. (Although one
can argue that users who know what UTF-8 is also knows how to set the
encoding back)

Until userspace is more capable of setting back the terminal to its
previous configuration, I would tend to agree with Jan, that we should
leave the current utf setting of that particular vc alone.

Tony



  reply	other threads:[~2007-04-03  0:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-02 14:13 [PATCH] vt: Do not clear UTF when resetting console Antonino A. Daplas
2007-04-02 17:35 ` H. Peter Anvin
2007-04-03  0:16   ` Antonino A. Daplas [this message]
2007-04-03  0:23     ` Jan Engelhardt
2007-04-03  0:53       ` Antonino A. Daplas
2007-04-03  0:55       ` H. Peter Anvin
2007-04-03 21:14         ` Paul LeoNerd Evans
2007-04-02 19:10 ` Jan Engelhardt
2007-04-03  0:16   ` Antonino A. Daplas
2007-04-03 11:41 ` Martin Mares
2007-04-03 14:51   ` Paul LeoNerd Evans
2007-04-03 15:37     ` Martin Mares
2007-04-04  5:42       ` Antonino A. Daplas
2007-04-04  8:12         ` Jan Engelhardt
2007-04-04  8:26           ` Paul LeoNerd Evans
2007-04-04 16:53         ` Martin Mares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175559377.7267.13.camel@daplas \
    --to=adaplas@gmail.com \
    --cc=akpm@osdl.org \
    --cc=hpa@zytor.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=leonerd@leonerd.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox