Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

David Brownell
2007-04-06T23:34:42Z

On Friday 06 April 2007 4:21 pm, Thomas Gleixner wrote:
> David,
>
> On Fri, 2007-04-06 at 15:57 -0700, David Brownell wrote:
> > This particular issue doesn't actually affect indentation, since the
> > tab trumps that space. So it's a bit off-agenda for this particular
> > flamage.
>
> ROTFL, the tab trumps the space. Is this a card game ?

Nah, just standard display algorithms. Alignment doesn't change.

> > > Please change your coding style to conform to Documentation/CodingStyle.
> > >
> > > *** Only indent with tabs!! ***
>
> How does your own rule make SPACE-TAB-TAB more acceptable than
> TAB-TAB-SPACE ? Just because TAB trumps the space but not the other way
> round ?

Because when you display the text, it doesn't affect the
alignment == indentation. In fact you have to turn on
nonstandard editor options to even see if this happened.
Not everyone does so, which is why such things persist.

So in practical terms "\n \t" and "\n\t" are identical;
although the former "should not" be used, it doesn't
actually affect what CodingStyle is primarily trying to
control (i.e. what the code looks like).

> You started nitpicking, so please accept the backfire.

Done.

:)