Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

Randy Dunlap
2007-04-06T21:40:11Z

David Brownell wrote:
> On Friday 06 April 2007 12:03 pm, Stefan Richter wrote:
>
>> I usually indent this way if expressions exceed the 80 columns limit:
>>
>> if (foo___________ &&
>> bar___________) {
>> doit;
>> }
>> and
>> if ((one___________ ||
>> one_and_a_half) &&
>> two___________) {
>> doit;
>> }
>> and
>> call(abc_______,
>> def___);
>> and
>>
>> static int definition(abc_______,
>> def___)
>> {
>> ...
>
> Please change your coding style to conform to Documentation/CodingStyle.
>
> *** Only indent with tabs!! ***
>
> Every one of those examples violates that simple rule.
>
> Why does *anyone* have even the slightest difficulty understanding such a
> simple rule? I realize that two of those words have more than a single
> syllable, but that should not be a problem. Even EMACS is trainable.
>
>
>> PS: Everyone please try to avoid blowing CodingStyle up to a 200 pages
>> document. Thanks.
>
> Better yet, try to stick to its guidelines rather than growing lots of
> exceptions saying when your personal style says you ought to use spaces
> instead of tabs for indents, etc
>
>
> Randy, next time you criticise coding style, please make sure that the
> code in question actually violates the existing rules first ... this
> thread has been way too much noise, given that the usage you criticized
> was in full conformance with that document, and the proposed fixes were
> in blatant violation ...

Yeah, well, I've already given up. But please try to understand,
David, that CodingStyle can have mistakes in it, just like some of
the kernel code does. And like I said earlier, it's just a set of
guidelines.

And I haven't seen any flamage here (referring to another posting).

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***