Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!

Jan Engelhardt
2007-04-04T20:08:26Z

On Apr 4 2007 12:00, Randy Dunlap wrote:
>
>> +static int __init fpga_init(void)
>> +{
>> + if (machine_is_omap_h4()
>> + || machine_is_omap_h3()
>> + || machine_is_omap_h2()
>> + || machine_is_omap_perseus2()
>> + )
>
>Perhaps there is nothing in CodingStyle for if () continuation
>lines. Looks like it is needed. This is ETOOMUCHINDENTATION by
>at least one tab. Should be more like:
>
>+ if (machine_is_omap_h4()
>+ || machine_is_omap_h3()
>+ || machine_is_omap_h2()
>+ || machine_is_omap_perseus2())

My stance, || goes at EOL, and final ) not standalone:

if (foo ||
bar ||
baz ||
etc)
do_something;

Jan
--