Re: [PATCH 63/90] ARM: OMAP: Merge PM code from N800 tree

Randy Dunlap
2007-04-04T21:51:20Z

On Wed, 4 Apr 2007 14:05:42 -0400 Tony Lindgren wrote:

> From: Kai Svahn <kai.svahn@nokia.com>
>
> This patch merges omap2 PM code from N800 tree.
>
> Patch adds support for sleep while idle for omap2
> and handy serial console debbugging code. It also
> moves code from pm-domain.c to pm.c.
>
> This code can be used as a base for developing
> power management for all omap24xx boards.
>
> ---
> arch/arm/mach-omap2/Makefile | 2 +-
> arch/arm/mach-omap2/pm-domain.c | 299 ------------
> arch/arm/mach-omap2/pm.c | 969 ++++++++++++++++++++++++++++-----------
> arch/arm/mach-omap2/sleep.S | 23 +-
> include/asm-arm/arch-omap/pm.h | 66 +---
> 5 files changed, 719 insertions(+), 640 deletions(-)

> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index d7eee99..1034eb9 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -6,6 +6,16 @@
> * Copyright (C) 2006 Nokia Corporation
> * Tony Lindgren <tony@atomide.com>
> *
> + * Fixed suspend-resume/dynamic-idle to get OMAP to retention
> + * Amit Kucheria <amit.kucheria@nokia.com>
> + * Igor Stoppa <igor.stoppa@nokia.com>
> + *
> + * Fixed MPU sleep to get ARM idle
> + * Igor Stoppa <igor.stoppa@nokia.com>
> + *
> + * Fixed MPU sleep some more
> + * Juha Yrjola
> + *

Changelog goes in the SCM metadata, not source files.

> +extern void omap2_gpio_prepare_for_retention(void);
> +extern void omap2_gpio_resume_after_retention(void);

externs in header files, please.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***