Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

Jeremy Fitzhardinge
2007-04-06T21:38:27Z

David Brownell wrote:
> Please change your coding style to conform to Documentation/CodingStyle.
>
> *** Only indent with tabs!! ***
>
> Every one of those examples violates that simple rule.
>

Spaces are used to indent all over the kernel; using a few spaces to pad
out some indentation into the proper place is accepted practice,
regardless of what CodingStyle says. The most important rule probably
needs to be explicitly added:

Break any of these rules sooner than say anything outright barbarous.[1]

Though the first para of CodingStyle is very clear that it is a set of
guidelines rather than strict rules.

J

1: http://www.k-1.com/Orwell/index.cgi/work/essays/language.html