Re: [PATCH 53/90] ARM: OMAP: Fix warning in timer32k.c

Tony Lindgren
2007-04-05T15:16:46Z

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

* Randy Dunlap <randy.dunlap@oracle.com> [070404 15:14]:
> On Wed, 4 Apr 2007 14:05:32 -0400 Tony Lindgren wrote:
>
> > From: Dirk Behme <dirk.behme_at_gmail.com>
>
> NAK the obfuscated email address.
> And in the S-O-B line as well.

Updated patch following. I'll also fix it in other patches
from Dirk:

55/90 ARM: OMAP: H3 workqueue fixes
56/90 ARM: OMAP: Make board palmz71 compile again
64/90 ARM: OMAP: Fix warning in pm.c

Tony

[-- Attachment #2: 0053-ARM-OMAP-Fix-warning-in-timer32k.c.txt --]
[-- Type: text/plain, Size: 1858 bytes --]

>From b78b9979fcdfd68604570f51ece0c43f17cd37ae Mon Sep 17 00:00:00 2001
From: Dirk Behme <dirk.behme@gmail.com>
Date: Thu, 25 Jan 2007 16:26:19 -0800
Subject: [PATCH 53/90] ARM: OMAP: Fix warning in timer32k.c

ARM: OMAP: Fix warning in timer32k.c if CONFIG_NO_IDLE_HZ
isn't set:

arch/arm/plat-omap/timer32k.c:221: warning:
'omap_32k_timer_handler' defined but not used

Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/timer32k.c | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm/plat-omap/timer32k.c b/arch/arm/plat-omap/timer32k.c
index c37d7b4..a98de90 100644
--- a/arch/arm/plat-omap/timer32k.c
+++ b/arch/arm/plat-omap/timer32k.c
@@ -217,6 +217,18 @@ static inline irqreturn_t _omap_32k_timer_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}

+static irqreturn_t omap_32k_timer_interrupt(int irq, void *dev_id)
+{
+ unsigned long flags;
+
+ write_seqlock_irqsave(&xtime_lock, flags);
+ _omap_32k_timer_interrupt(irq, dev_id);
+ write_sequnlock_irqrestore(&xtime_lock, flags);
+
+ return IRQ_HANDLED;
+}
+
+#ifdef CONFIG_NO_IDLE_HZ
static irqreturn_t omap_32k_timer_handler(int irq, void *dev_id)
{
unsigned long now;
@@ -233,18 +245,6 @@ static irqreturn_t omap_32k_timer_handler(int irq, void *dev_id)
return _omap_32k_timer_interrupt(irq, dev_id);
}

-static irqreturn_t omap_32k_timer_interrupt(int irq, void *dev_id)
-{
- unsigned long flags;
-
- write_seqlock_irqsave(&xtime_lock, flags);
- _omap_32k_timer_interrupt(irq, dev_id);
- write_sequnlock_irqrestore(&xtime_lock, flags);
-
- return IRQ_HANDLED;
-}
-
-#ifdef CONFIG_NO_IDLE_HZ
/*
* Programs the next timer interrupt needed. Called when dynamic tick is
* enabled, and to reprogram the ticks to skip from pm_idle. Note that
--
1.4.4.2