Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!

David Brownell
2007-04-04T20:51:24Z

On Wednesday 04 April 2007 1:06 pm, Jan Engelhardt wrote:
>
> On Apr 4 2007 12:00, Randy Dunlap wrote:
> >
> >> +static int __init fpga_init(void)
> >> +{
> >> + if (machine_is_omap_h4()
> >> + || machine_is_omap_h3()
> >> + || machine_is_omap_h2()
> >> + || machine_is_omap_perseus2()
> >> + )
> >
> >Perhaps there is nothing in CodingStyle for if () continuation
> >lines. Looks like it is needed. This is ETOOMUCHINDENTATION by
> >at least one tab. Should be more like:
> >
> >+ if (machine_is_omap_h4()
> >+ || machine_is_omap_h3()
> >+ || machine_is_omap_h2()
> >+ || machine_is_omap_perseus2())
>
> My stance, || goes at EOL, and final ) not standalone:

You are still violating the "only TABs used for indent" rule.

> if (foo ||
> bar ||
> baz ||
> etc)
> do_something;
>
>
>
> Jan
> --
>