From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [S390] page_mkclean data corruption.
Date: Wed, 04 Apr 2007 22:14:04 +0200 [thread overview]
Message-ID: <1175717644.6483.89.camel@twins> (raw)
In-Reply-To: <461405F5.6010303@redhat.com>
> > ---
> > mm/rmap.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/rmap.c b/mm/rmap.c
> > index 22ed3f7..b82146e 100644
> > --- a/mm/rmap.c
> > +++ b/mm/rmap.c
> > @@ -498,9 +498,9 @@ int page_mkclean(struct page *page)
> > struct address_space *mapping = page_mapping(page);
> > if (mapping)
> > ret = page_mkclean_file(mapping, page);
> > + if (page_test_and_clear_dirty(page))
> > + ret = 1;
> > }
> > - if (page_test_and_clear_dirty(page))
> > - ret = 1;
> >
> > return ret;
> > }
>
> This changes generic mm code. Is S390 really the only affected architecture?
Yeah, its the only arch where page_test_and_clear_dirty() is not 0
next prev parent reply other threads:[~2007-04-04 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200704041759.l34HxCnm014838@hera.kernel.org>
2007-04-04 20:09 ` [S390] page_mkclean data corruption Chuck Ebbert
2007-04-04 20:14 ` Peter Zijlstra [this message]
2007-04-04 16:37 Martin Schwidefsky
2007-04-04 17:10 ` Linus Torvalds
2007-04-04 17:35 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175717644.6483.89.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox