From: Daniel Walker <dwalker@mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
tglx@linutronix.de, johnstul@us.ibm.com,
LKML <linux-kernel@vger.kernel.org>,
heiko.carstens@de.ibm.com
Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree
Date: Wed, 04 Apr 2007 13:44:49 -0700 [thread overview]
Message-ID: <1175719489.15973.66.camel@imap.mvista.com> (raw)
In-Reply-To: <20070404203647.GA12563@elte.hu>
On Wed, 2007-04-04 at 22:36 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker@mvista.com> wrote:
>
> > The struct clocksource .list field is now required to be initialized
> > before calling clocksource_register().
> >
> > This is a prerequisite for simplifying the clocksource registration
> > process.
>
> why? This patch only pushes some unnecessary code into the clocksource
> drivers:
>
> + .list = LIST_HEAD_INIT(clocksource_avr32.list),
>
> NACK unless you can give an explanation of why this is unavoidable. A
> NULL initializer is just as good as an initialized list entry. (in fact
> it's slightly better because it's in the kernel's BSS)
This is only 1 of 9 patches . The 9th patch requires the .list value to
be initialized .. The description change above was suppose to make that
clearer .. By forcing the .list value to be initialized we can simplify
the clocksource registration .
Daniel
next prev parent reply other threads:[~2007-04-04 20:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200704010523.l315NXJP004063@shell0.pdx.osdl.net>
2007-04-01 8:43 ` + clocksource-driver-initialize-list-value.patch added to -mm tree Thomas Gleixner
2007-04-04 16:38 ` Daniel Walker
2007-04-04 19:58 ` Andrew Morton
2007-04-04 20:10 ` Daniel Walker
2007-04-04 20:36 ` Ingo Molnar
2007-04-04 20:44 ` Daniel Walker [this message]
2007-04-04 21:15 ` Ingo Molnar
2007-04-04 21:30 ` Daniel Walker
2007-04-04 21:34 ` Ingo Molnar
2007-04-04 21:59 ` Daniel Walker
2007-04-04 23:48 ` Jeremy Fitzhardinge
2007-04-05 0:00 ` Daniel Walker
2007-04-05 0:20 ` Jeremy Fitzhardinge
2007-04-05 0:34 ` Daniel Walker
2007-04-05 6:02 ` Thomas Gleixner
2007-04-05 7:51 ` Ingo Molnar
2007-04-05 11:35 ` Daniel Walker
2007-04-04 20:48 ` Andrew Morton
2007-04-04 21:47 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175719489.15973.66.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox