From: Thomas Gleixner <tglx@linutronix.de>
To: Daniel Walker <dwalker@mvista.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
johnstul@us.ibm.com, LKML <linux-kernel@vger.kernel.org>,
heiko.carstens@de.ibm.com
Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree
Date: Thu, 05 Apr 2007 08:02:33 +0200 [thread overview]
Message-ID: <1175752953.28263.374.camel@localhost.localdomain> (raw)
In-Reply-To: <1175733279.15973.116.camel@imap.mvista.com>
On Wed, 2007-04-04 at 17:34 -0700, Daniel Walker wrote:
> > The fact that a list is used to string together clocksource structures
> > is an internal detail of the clock subsystem. It's annoying that there
> > has to be a list head in the clocksource structure, but at least as a
> > clocksource implementer I can ignore it, and if it ever gets changed to
> > something else I can keep ignoring it. Your change makes it something
> > that gets pointlessly replicated all over the kernel.
>
> It's already been discussed in the past, but the clocksource structure
> is already very simple.. Adding a list initializer doesn't change
> anything..
And it does not gain anything.
So what's the gain of this ? Nine useless entries in the changelog.
tglx
next prev parent reply other threads:[~2007-04-05 6:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200704010523.l315NXJP004063@shell0.pdx.osdl.net>
2007-04-01 8:43 ` + clocksource-driver-initialize-list-value.patch added to -mm tree Thomas Gleixner
2007-04-04 16:38 ` Daniel Walker
2007-04-04 19:58 ` Andrew Morton
2007-04-04 20:10 ` Daniel Walker
2007-04-04 20:36 ` Ingo Molnar
2007-04-04 20:44 ` Daniel Walker
2007-04-04 21:15 ` Ingo Molnar
2007-04-04 21:30 ` Daniel Walker
2007-04-04 21:34 ` Ingo Molnar
2007-04-04 21:59 ` Daniel Walker
2007-04-04 23:48 ` Jeremy Fitzhardinge
2007-04-05 0:00 ` Daniel Walker
2007-04-05 0:20 ` Jeremy Fitzhardinge
2007-04-05 0:34 ` Daniel Walker
2007-04-05 6:02 ` Thomas Gleixner [this message]
2007-04-05 7:51 ` Ingo Molnar
2007-04-05 11:35 ` Daniel Walker
2007-04-04 20:48 ` Andrew Morton
2007-04-04 21:47 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175752953.28263.374.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jeremy@goop.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox