From: Rusty Russell <rusty@rustcorp.com.au>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Re: kernel oops with badly formatted module option
Date: Mon, 09 Apr 2007 11:24:22 +1000 [thread overview]
Message-ID: <1176081862.11664.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20070407194700.38138108.randy.dunlap@oracle.com>
On Sat, 2007-04-07 at 19:47 -0700, Randy Dunlap wrote:
> On Sat, 07 Apr 2007 19:21:01 -0500 Larry Finger wrote:
>
> > With the following line in /etc/modprobe.conf.local:
> >
> > options bcm43xx fwpostfix = ".fw3" locale=8
> >
> > the kernel oops below is generated. I realize that the line should have no whitespace around the
> > "=", but I do not feel that an oops is the best way to report the syntax error. Could there be a more gentle failure?
>
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Catch malformed kernel parameter usage of "param = value".
> Spaces are not supported, but don't cause a kernel fault on
> such usage, just report an error.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks Randy,
I even read your patch before I wrote my own, for a change!
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
prev parent reply other threads:[~2007-04-09 1:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-08 0:21 kernel oops with badly formatted module option Larry Finger
2007-04-08 2:47 ` [PATCH] " Randy Dunlap
2007-04-08 3:43 ` Larry Finger
2007-04-09 1:24 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176081862.11664.6.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox