From: Rusty Russell <rusty@rustcorp.com.au>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] Clean up x86 control register and MSR macros
Date: Wed, 11 Apr 2007 14:11:06 +1000 [thread overview]
Message-ID: <1176264666.26372.101.camel@localhost.localdomain> (raw)
In-Reply-To: <461BC9DE.5030009@zytor.com>
On Tue, 2007-04-10 at 10:31 -0700, H. Peter Anvin wrote:
> Jeremy Fitzhardinge wrote:
> >
> > Is having separate bit numbers and masks useful? If so, is it worth
> > doing for the others?
> >
>
> I presume it's useful, or at least *used* in the current code, since
> that was there already. If deemed useful, it's something we could add
> to the other bitmasks.
I don't think it needs to be done now, as long as it follows a clear
convention. I'd prefer eg. X86_EFLAGS_IF_BIT == 9, X86_EFLAGS_IF ==
512, but _X86_EFLAGS_IF seems to be the current practice.
Cheers,
Rusty.
prev parent reply other threads:[~2007-04-11 4:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 16:48 H. Peter Anvin
2007-04-10 17:03 ` [PATCH] Clean up x86 control register and MSR macros Jeremy Fitzhardinge
2007-04-10 17:31 ` H. Peter Anvin
2007-04-11 4:11 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176264666.26372.101.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox