From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751520AbdBUFfV (ORCPT ); Tue, 21 Feb 2017 00:35:21 -0500 Received: from mx3-phx2.redhat.com ([209.132.183.24]:42314 "EHLO mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751144AbdBUFfF (ORCPT ); Tue, 21 Feb 2017 00:35:05 -0500 Date: Tue, 21 Feb 2017 00:34:59 -0500 (EST) From: David Airlie To: Thomas Hellstrom Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Daniel Vetter , linux-kernel@vger.kernel.org Message-ID: <1176275231.24491633.1487655299858.JavaMail.zimbra@redhat.com> In-Reply-To: <44292f61-80ce-bf39-8a22-8ac685586af0@shipmail.org> References: <20161028081050.1042-1-daniel.vetter@ffwll.ch> <07f5e4a3-f7ef-df5e-d8cc-3759d828719d@shipmail.org> <44292f61-80ce-bf39-8a22-8ac685586af0@shipmail.org> Subject: Re: DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.40.34] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF50 (Linux)/8.0.6_GA_5922) Thread-Topic: DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes) Thread-Index: I5cCSkbPnEM6j1NuZMaeB4+gUzVJuA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > No. > > IMO Not fixing this immediately through stable is out of the question. > The deal is that we don't break userspace. > Having said that, I'm not against a long term vmwgfx-only solution. But > let's fix this now. > > Admittedly we missed testing this but you got to understand that not all > developer teams have a multitude of > developers (we have on average one for the whole linux graphics driver > stack except GL), and the bug > doesn't show up for QE on regression testing unless they run > gnome-sheel/Wayland which they currently don't, and I guess they've been > focused on the fb2 regression. > > It's no secret that we've been using the control nodes for some time. > The CONTROL_ALLOW is present in the > driver private ioctls and the commit has been there since 2016. > > The user-space code has been present in vmware-tools also since that > commit and due to the long release cycles of > open-vm-tools the open-vm-tools version was just about to be released. > It's necessary for non-xorg can you send a revert against drm-next? I'm not sure how clean it will be. there might be an intermediate step. Then can we port vmtools of this behaviour, not even sure what it is doing. Dave.