From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752699AbbBXNeW (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Feb 2015 08:34:22 -0500
Received: from mout.kundenserver.de ([212.227.17.10]:50601 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752098AbbBXNeV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Feb 2015 08:34:21 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Marek Vasut <marex@denx.de>, Wolfram Sang <wsa@the-dreams.de>,
        linux-kernel <linux-kernel@vger.kernel.org>, linux-spi@vger.kernel.org,
        Mark Brown <broonie@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Barry Song <Baohua.Song@csr.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH] spi: sirf: add reset controller dependency
Date: Tue, 24 Feb 2015 14:34:06 +0100
Message-ID: <11771349.MCSxFTdomh@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAGb2v64hgW39c+gQXp-btpOu2_ddEnGBQk7udMGatCG8We+dBQ@mail.gmail.com>
References: <4553005.HBquOfbqXe@wuerfel> <5840299.CR2H70RAJi@wuerfel> <CAGb2v64hgW39c+gQXp-btpOu2_ddEnGBQk7udMGatCG8We+dBQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:WqYw6KzBGH3qve7nl84JtwRhH6pvrPrPsTBma06NrBa00fhj0+4
 lzvva+tmmOO3s2r+l8PMFp8KRFOVC1SK2EOWCwnt4clkIrYQ3bTg4sr/fcdTX7y6V+zu5tL
 CxIEuY/H0dv1cZ7c0VTtk8dj55dv2Qli4GTnrrgdWEi6xGggeC9gVKU/uE0FpXLEIdX3Od+
 t6lJL4lqJitSqfWdYKGtQ==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 24 February 2015 18:56:44 Chen-Yu Tsai wrote:
> > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> > @@ -1,11 +1,11 @@
> >  config STMMAC_ETH
> >         tristate "STMicroelectronics 10/100/1000 Ethernet driver"
> >         depends on HAS_IOMEM && HAS_DMA
> > +       depends on RESET_CONTROLLER
> >         select MII
> >         select PHYLIB
> >         select CRC32
> >         select PTP_1588_CLOCK
> > -       select RESET_CONTROLLER
> 
> I was the one that introduced this. At the time a generic binding for the
> stmmac core was requested, which supported an optional reset control. There
> wasn't an *_optional stub available, so I went with this. See
> 
>     http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/224684.html
> b424080a9e08
> With commit b424080a9e08 ("reset: Add optional resets and stubs") in, I
> think using devm_reset_control_get() in the driver is the proper solution.
> The hardware is found in quite a few platforms, and not all of them have
> reset controllers.

I suppose you mean devm_reset_control_get_option() instead of
devm_reset_control_get()?

Yes, that sounds right.

	Arnd