Re: [PATCH 7/8] Kconfig: silicon backplane dependency.

Michael Buesch
2007-04-20T20:46:43Z

On Friday 20 April 2007 13:35, Martin Schwidefsky wrote:
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> Make the "Sonics Silicon Backplane" menu dependent on the two buses
> it can be found on.
> Goes on top of git-wireless.patch.
>
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: John W. Linville <linville@tuxdriver.com>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> ---
>
> drivers/ssb/Kconfig | 1 +
> 1 files changed, 1 insertion(+)
>
> diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig
> --- linux-2.6/drivers/ssb/Kconfig 2007-04-19 15:24:40.000000000 +0200
> +++ linux-2.6-patched/drivers/ssb/Kconfig 2007-04-19 15:55:44.000000000 +0200
> @@ -1,4 +1,5 @@
> menu "Sonics Silicon Backplane"
> + depends on PCI || PCMCIA

This is wrong. SSB does not depend on PCI or PCMCIA.
SSB can (and does) stay very well on its own feet and
can be the main system bus.
Most Linksys WRT routers work that way. They have no
PCI bus, but a SSB bus instead.

Nevertheless, I'm not sure what your problem really is.
Does a s390 machine exist with a B44 card? I doubt it.
So what about the following: We simply add
a DEPENDS ON !S390 to both SSB and B44.
I really thing that is the right fix for this.
The patch above is clearly not, as it breaks things for
embedded devices without PCI or PCMCIA bus.

--
Greetings Michael.