From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754448AbXDWWxK (ORCPT ); Mon, 23 Apr 2007 18:53:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754449AbXDWWxK (ORCPT ); Mon, 23 Apr 2007 18:53:10 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:57202 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754441AbXDWWxH (ORCPT ); Mon, 23 Apr 2007 18:53:07 -0400 Subject: Re: 2.6.21-rc7: HPET enabled freeze my machine at boot From: john stultz To: "Guilherme M. Schroeder" Cc: linux-kernel@vger.kernel.org, Thomas Gleixner In-Reply-To: <1177367429.12242.7.camel@localhost> References: <4627D7CF.3070002@centralinf.com.br> <1f1b08da0704201453i1b2388der1dfe778633fbf6ea@mail.gmail.com> <462A9926.2030303@centralinf.com.br> <1177367429.12242.7.camel@localhost> Content-Type: text/plain Date: Mon, 23 Apr 2007 15:53:05 -0700 Message-Id: <1177368785.12242.9.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2007-04-23 at 15:30 -0700, john stultz wrote: > On Sat, 2007-04-21 at 20:07 -0300, Guilherme M. Schroeder wrote: > > john stultz wrote: > > > On 4/19/07, guilherme wrote: > > >> Hi, > > >> > > >> If i enable "High Resolution Timer Support", my machine stops here at > > >> boot: > > >> > > >> Clocksource tsc unstable (delta = -297340790165 ns) > > >> Time: hpet clocksource has been installed. > > >> > > >> If i disable HPET, it boots fine. > > > > > > Hmmm.. What happens if you boot w/ clocksource=acpi_pm ? > > > > > > > > > > Boot ok with clocksource=acpi_pm and HPET enabled. > > Any clue? > > > I'm suspecting that your HPET counter is being stopped for some reason, > although why I have no idea. > > Just to get a clear picture, does this happen w/ "Tickless System > (Dynamic ticks)" disabled in the menuconfig? > > Thomas, might we be actually stopping the HPET counter instead of > disabling the HPET interrupt w/ dynticks? Just a shot in the dark, but does this patch affect the behavior? thanks -john diff --git a/arch/i386/kernel/hpet.c b/arch/i386/kernel/hpet.c index 17d7345..14e76a5 100644 --- a/arch/i386/kernel/hpet.c +++ b/arch/i386/kernel/hpet.c @@ -183,9 +183,6 @@ static void hpet_set_mode(enum clock_event_mode mode, case CLOCK_EVT_MODE_UNUSED: case CLOCK_EVT_MODE_SHUTDOWN: - cfg = hpet_readl(HPET_T0_CFG); - cfg &= ~HPET_TN_ENABLE; - hpet_writel(cfg, HPET_T0_CFG); break; } }