public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasily Tarasov <vtaras@openvz.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: OVZDL <devel@openvz.org>
Subject: Re: [PATCH] cfq: get rid of cfqq hash
Date: Tue, 24 Apr 2007 16:51:06 +0400	[thread overview]
Message-ID: <1177419066.344602.20693.nullmailer@me> (raw)
In-Reply-To: <20070424122739.GJ3744@kernel.dk>

>> From: Vasily Tarasov <vtaras@openvz.org>
>> 
>> cfq hash is no more necessary.  We always can get cfqq from io context.
>> cfq_get_io_context_noalloc() function is introduced, because we don't want
>> to
>> allocate cic on merging and checking may_queue.
>> In order to identify sync queue we've used hash key = CFQ_KEY_ASYNC. Since
>> hash
>> is eliminated we need to use other criterion: sync flag for queue is added.
>> In all places where we dig in rb_tree we're in current context, so no
>> additional locking is required.
>> 
>> 
>> Advantages of this patch: no additional memory for hash, no seeking in hash,
>> code is cleaner. But it is necessary now to seek cic in per-ioc rbtree, but
>> it is faster:
>> - most processes work only with few devices
>> - most systems have only few block devices
>> - it is a rb-tree
>
> Vasily, thanks for doing this, it's a good cleanup. One request, though
> - care to rebase this against the cfq devel branch? I'm afraid it's
> nowhere near applying right now.
> -- 
> Jens Axboe

Ouch, I see the sources are changed since the moment I was getting them...
I'll resend a fresh version!



  reply	other threads:[~2007-04-24 12:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-24 11:53 [PATCH] cfq: get rid of cfqq hash Vasily Tarasov
2007-04-24 12:27 ` Jens Axboe
2007-04-24 12:51   ` Vasily Tarasov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-04-24 13:53 Vasily Tarasov
2007-04-24 17:02 ` Jens Axboe
2007-04-24 17:22   ` Jens Axboe
2007-04-24 18:29     ` Jens Axboe
2007-04-24 18:33       ` Jens Axboe
2007-04-25 11:31     ` Vasily Tarasov
2007-04-25  6:58 ` Jens Axboe
2007-04-25  7:27   ` Jens Axboe
2007-04-25 11:50   ` Vasily Tarasov
2007-04-25  7:57     ` Jens Axboe
2007-04-25 10:27       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1177419066.344602.20693.nullmailer@me \
    --to=vtaras@openvz.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox