From: Vasily Tarasov <vtaras@openvz.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: OVZDL <devel@openvz.org>
Subject: Re: [PATCH] cfq: get rid of cfqq hash
Date: Wed, 25 Apr 2007 15:50:27 +0400 [thread overview]
Message-ID: <1177501827.988228.3870.nullmailer@me> (raw)
In-Reply-To: <20070425065822.GG9715@kernel.dk>
>> @@ -1806,7 +1765,11 @@ static int cfq_may_queue(request_queue_t
>> * so just lookup a possibly existing queue, or return 'may queue'
>> * if that fails
>> */
>> - cfqq = cfq_find_cfq_hash(cfqd, key, tsk->ioprio);
>> + cic = cfq_get_io_context_noalloc(cfqd, tsk);
>> + if (!cic)
>> + return ELV_MQUEUE_MAY;
>> +
>> + cfqq = cic->cfqq[rw & REQ_RW_SYNC];
>> if (cfqq) {
>> cfq_init_prio_data(cfqq);
>> cfq_prio_boost(cfqq);
>
> Ahem, how well did you test this patch?
Ugh, again: bio_sync() returns not only 0/1
Sorry for giving so much trouble...
BTW, what tests do you use to check patches?
I'll run them on our nodes each time when sending it to you.
At the moment I use some self made tests and a bit fio scripts.
>
> --
> Jens Axboe
next prev parent reply other threads:[~2007-04-25 7:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 13:53 [PATCH] cfq: get rid of cfqq hash Vasily Tarasov
2007-04-24 17:02 ` Jens Axboe
2007-04-24 17:22 ` Jens Axboe
2007-04-24 18:29 ` Jens Axboe
2007-04-24 18:33 ` Jens Axboe
2007-04-25 11:31 ` Vasily Tarasov
2007-04-25 6:58 ` Jens Axboe
2007-04-25 7:27 ` Jens Axboe
2007-04-25 11:50 ` Vasily Tarasov [this message]
2007-04-25 7:57 ` Jens Axboe
2007-04-25 10:27 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2007-04-24 11:53 Vasily Tarasov
2007-04-24 12:27 ` Jens Axboe
2007-04-24 12:51 ` Vasily Tarasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1177501827.988228.3870.nullmailer@me \
--to=vtaras@openvz.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox