From: john stultz <johnstul@us.ibm.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Peter Keilty <peter.keilty@hp.com>,
linux-ia64@vger.kernel.org, Eric Whitney <eric.whitney@hp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ia64: convert to use clocksource code
Date: Thu, 26 Apr 2007 13:48:41 -0700 [thread overview]
Message-ID: <1177620521.6031.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20070426204146.GA25142@uranus.ravnborg.org>
On Thu, 2007-04-26 at 22:41 +0200, Sam Ravnborg wrote:
> On Thu, Apr 26, 2007 at 04:26:32PM -0400, Peter Keilty wrote:
> > From: Peter Keilty <peter.keilty@hp.com>
> >
> > Initial ia64 conversion to the generic timekeeping/clocksource code.
> >
> > Signed-off-by: Peter Keilty <peter.keilty@hp.com>
> > Signed-off-by: John Stultz <johnstul@us.ibm.com>
>
> The "Signed-off-by:" should reflect the order in which a path is processed
> with the last submitter at the bottom of the list.
> So if this patch came from John then he should be first in the list
> and since the patch passes you and you submit it you should be in the bottom
> of the list.
>
> And "Signed-off-by:" tell the path that the patch takes. It is not to be used
> to let others say "I have seen it and I think the patch is ok".
> For the latter we have "Acked-by:".
Yea. Its a little odd in this case, because Peter sent me the signed off
code, then I've made tweaks to it and signed it off, then peter picked
that up and has made further improvements.
So I don't think it is inaccurate, but I see how it could be confusing.
Maybe Peter should add an extra signed-off so its more clear?
thanks
-john
next prev parent reply other threads:[~2007-04-26 20:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 20:26 [PATCH 1/3] ia64: convert to use clocksource code Peter Keilty
2007-04-26 20:27 ` [PATCH 2/3] ia64: remove interpolater code Peter Keilty
2007-04-26 20:52 ` john stultz
2007-04-26 21:47 ` David Miller
2007-04-26 20:27 ` [PATCH 3/3] ia64: update fsyscall for performance, enable build/run on 2.6.21-rc1 Peter Keilty
2007-04-26 20:41 ` [PATCH 1/3] ia64: convert to use clocksource code Sam Ravnborg
2007-04-26 20:48 ` john stultz [this message]
2007-04-26 21:07 ` Daniel Walker
2007-04-27 14:38 ` Peter Keilty
2007-04-27 15:35 ` Daniel Walker
2007-04-27 15:42 ` Peter Keilty
2007-04-27 15:48 ` Daniel Walker
2007-04-27 16:11 ` Peter Keilty
2007-04-27 16:32 ` Daniel Walker
2007-05-02 17:58 ` john stultz
2007-05-02 19:08 ` Daniel Walker
2007-04-26 21:18 ` john stultz
2007-04-27 12:54 ` Peter Keilty
2007-05-02 17:50 ` john stultz
2007-04-27 1:02 ` Chris Wright
2007-04-27 13:35 ` Peter Keilty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1177620521.6031.2.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=eric.whitney@hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.keilty@hp.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox