From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH -rt] yet another irq storm
Date: Fri, 27 Apr 2007 23:12:44 -0400 [thread overview]
Message-ID: <1177729964.19619.3.camel@localhost.localdomain> (raw)
Must be global warming, I'm getting a lot more irq storms than usual.
Now that I switched over to x86_64, I booted up and got another irq
storm. So I added my previous patch and it didn't fix it. Looking
further, I found that the mask and unmask is done directly in the
x86_64/io_apic.c file.
This patch does basically the same thing as my previous patch, but to
the x86_64/io_apic.c file.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Index: linux-2.6.21-rt1/arch/x86_64/kernel/io_apic.c
===================================================================
--- linux-2.6.21-rt1.orig/arch/x86_64/kernel/io_apic.c
+++ linux-2.6.21-rt1/arch/x86_64/kernel/io_apic.c
@@ -1437,7 +1437,8 @@ static void ack_apic_level(unsigned int
irq_complete_move(irq);
#if defined(CONFIG_GENERIC_PENDING_IRQ) || defined(CONFIG_IRQBALANCE)
/* If we are moving the irq we need to mask it */
- if (unlikely(irq_desc[irq].status & IRQ_MOVE_PENDING)) {
+ if (unlikely(irq_desc[irq].status & IRQ_MOVE_PENDING) &&
+ !(irq_desc[irq].status & IRQ_INPROGRESS)) {
do_unmask_irq = 1;
mask_IO_APIC_irq(irq);
}
reply other threads:[~2007-04-28 3:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1177729964.19619.3.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox