From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030190AbXD1VGs (ORCPT ); Sat, 28 Apr 2007 17:06:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753423AbXD1VGs (ORCPT ); Sat, 28 Apr 2007 17:06:48 -0400 Received: from www.osadl.org ([213.239.205.134]:53881 "EHLO mail.tglx.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753152AbXD1VGq (ORCPT ); Sat, 28 Apr 2007 17:06:46 -0400 Subject: Re: Flaws with "UIO: Add the User IO core code" (with patch) From: Thomas Gleixner Reply-To: tglx@linutronix.de To: =?ISO-8859-1?Q?Hans-J=FCrgen?= Koch Cc: Alan Cox , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, torvalds@osdl.org, Benedikt Spranger In-Reply-To: <200704282303.06727.hjk@linutronix.de> References: <20070427224957.GA17967@kroah.com> <200704282052.45489.hjk@linutronix.de> <20070428212416.5768cc04@the-village.bc.nu> <200704282303.06727.hjk@linutronix.de> Content-Type: text/plain; charset=utf-8 Date: Sat, 28 Apr 2007 23:08:51 +0200 Message-Id: <1177794532.7646.313.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2007-04-28 at 23:03 +0200, Hans-Jürgen Koch wrote: > Am Samstag 28 April 2007 22:24 schrieb Alan Cox: > > > > AFAIK we don't currently have any platform that runs binaries with > > > > different sizes of "int" but this is a) an unsigned value anyway, and b) > > > > should be a fixed type (eg u32) > > > > > > I reviewed the code once more and find it OK. There is only one legal > > > value for the parameter "count" of uio_read(), and that's sizeof(int). > > > > If you are a box with multiple supported binary types how big is an > > "int". We use explicit sizes to ensure that uio_read() will work when/if > > we get platforms which support binaries with differing ideas of the size > > of "int". Thus it should use s32 or s64 or similar. > > Here's a fix to that effect: Can you please add a matching paragraph to the documentation ? tglx