Re: [patch 5/9] IEEE1394: Spinlock initializer cleanup

Re: [patch 5/9] IEEE1394: Spinlock initializer cleanup

[Stefan Richter]

Thomas Gleixner wrote:
> --- linux-2.6.orig/drivers/ieee1394/ieee1394_transactions.c
> +++ linux-2.6/drivers/ieee1394/ieee1394_transactions.c
> @@ -32,7 +32,7 @@
>  #ifndef HPSB_DEBUG_TLABELS
>  static
>  #endif
> -spinlock_t hpsb_tlabel_lock = SPIN_LOCK_UNLOCKED;
> +DEFINE_SPINLOCK(hpsb_tlabel_lock);

We've got already an identical patch from Milind Arun Choudhary,
http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff;h=ca79b9d41152ff8605ed5503fd4cbfe0ea60ee7f
in linux1394-2.6.git/master and hence in -mm.  It'll be part of the post
2.6.21 pull request I'll send out RSN, unless your patch bypasses me
somehow.
-- 
Stefan Richter
-=====-=-=== -=-- ===-=
http://arcgraph.de/sr/

Re: [patch 5/9] IEEE1394: Spinlock initializer cleanup

[Thomas Gleixner]

On Sun, 2007-04-29 at 18:43 +0200, Stefan Richter wrote:
> Thomas Gleixner wrote:
> > --- linux-2.6.orig/drivers/ieee1394/ieee1394_transactions.c
> > +++ linux-2.6/drivers/ieee1394/ieee1394_transactions.c
> > @@ -32,7 +32,7 @@
> >  #ifndef HPSB_DEBUG_TLABELS
> >  static
> >  #endif
> > -spinlock_t hpsb_tlabel_lock = SPIN_LOCK_UNLOCKED;
> > +DEFINE_SPINLOCK(hpsb_tlabel_lock);
> 
> We've got already an identical patch from Milind Arun Choudhary,
> http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff;h=ca79b9d41152ff8605ed5503fd4cbfe0ea60ee7f
> in linux1394-2.6.git/master and hence in -mm.  It'll be part of the post
> 2.6.21 pull request I'll send out RSN, unless your patch bypasses me
> somehow.

Missed that one.

Thanks,

	tglx


	

Re: [patch 3/9] AVR32: Spinlock initializer cleanup

[Haavard Skinnemoen]

On Sun, 29 Apr 2007 16:10:34 -0000
Thomas Gleixner <tglx@linutronix.de> wrote:

> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Applied to my avr32-arch branch. Thanks.

Where did the rest of the series go, btw? I didn't see any patches on
LKML...

Haavard

Re: [patch 3/9] AVR32: Spinlock initializer cleanup

[Thomas Gleixner]

On Mon, 2007-04-30 at 17:30 +0200, Haavard Skinnemoen wrote:
> On Sun, 29 Apr 2007 16:10:34 -0000
> Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
> Applied to my avr32-arch branch. Thanks.
> 
> Where did the rest of the series go, btw? I didn't see any patches on
> LKML...

My script did something wrong and vger ate it. Not sure what happened,
it's the same script I use since years. Will resend tomorrow, when I
know what the breakage is.

	tglx