[PATCH] VIDEO4LINUX-2: Replace MINOR() with a call to iminor().

[PATCH] VIDEO4LINUX-2: Replace MINOR() with a call to iminor().

[Robert P. J. Day]

Replace the call to MINOR() with a call to the inline iminor()
routine.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

that's the last of those changes, but it's not clear who the official
maintainer is, so i took a chance and picked a likely looking victim
out of the MAINTAINERS file.  apologies if i picked wrong.


diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/drivers/media/video/ivtv/ivtv-fileops.c
index 1637097..8976487 100644
--- a/drivers/media/video/ivtv/ivtv-fileops.c
+++ b/drivers/media/video/ivtv/ivtv-fileops.c
@@ -804,7 +804,7 @@ int ivtv_v4l2_open(struct inode *inode, struct file *filp)
 	struct ivtv_open_id *item;
 	struct ivtv *itv = NULL;
 	struct ivtv_stream *s = NULL;
-	int minor = MINOR(inode->i_rdev);
+	int minor = iminor(inode);

 	/* Find which card this open was on */
 	spin_lock(&ivtv_cards_lock);
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] VIDEO4LINUX-2: Replace MINOR() with a call to iminor().

[Mauro Carvalho Chehab]

Hi Robert,

Em Sáb, 2007-04-28 às 06:32 -0400, Robert P. J. Day escreveu:
> Replace the call to MINOR() with a call to the inline iminor()
> routine.
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> ---
> 
> that's the last of those changes, but it's not clear who the official
> maintainer is, so i took a chance and picked a likely looking victim
> out of the MAINTAINERS file.  apologies if i picked wrong.

You've picked it wrongly. The Maintainer for ivtv is Hans Verkuil.
However, for every stuff under drivers/media, you can reach the active
maintainers at v4l-dvb-maintainers list
(v4l-dvb-maintainer@linuxtv.org).

Hans,

If you are ok with this trivial change, please send me your acked-by or
SOB for me to commit and send to mainstream.
> 
> 
> diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/drivers/media/video/ivtv/ivtv-fileops.c
> index 1637097..8976487 100644
> --- a/drivers/media/video/ivtv/ivtv-fileops.c
> +++ b/drivers/media/video/ivtv/ivtv-fileops.c
> @@ -804,7 +804,7 @@ int ivtv_v4l2_open(struct inode *inode, struct file *filp)
>  	struct ivtv_open_id *item;
>  	struct ivtv *itv = NULL;
>  	struct ivtv_stream *s = NULL;
> -	int minor = MINOR(inode->i_rdev);
> +	int minor = iminor(inode);
> 
>  	/* Find which card this open was on */
>  	spin_lock(&ivtv_cards_lock);
-- 
Cheers,
Mauro

Re: [v4l-dvb-maintainer] Re: [PATCH] VIDEO4LINUX-2: Replace MINOR() with a call to iminor().

[Hans Verkuil]

> Hi Robert,
>
> Em Sáb, 2007-04-28 às 06:32 -0400, Robert P. J. Day escreveu:
>> Replace the call to MINOR() with a call to the inline iminor()
>> routine.
>>
>> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>>
>> ---
>>
>> that's the last of those changes, but it's not clear who the official
>> maintainer is, so i took a chance and picked a likely looking victim
>> out of the MAINTAINERS file.  apologies if i picked wrong.
>
> You've picked it wrongly. The Maintainer for ivtv is Hans Verkuil.
> However, for every stuff under drivers/media, you can reach the active
> maintainers at v4l-dvb-maintainers list
> (v4l-dvb-maintainer@linuxtv.org).
>
> Hans,
>
> If you are ok with this trivial change, please send me your acked-by or
> SOB for me to commit and send to mainstream.

Acked-by: Hans Verkuil <hverkuil@xs4all.nl>

Regards,

       Hans

>>
>>
>> diff --git a/drivers/media/video/ivtv/ivtv-fileops.c
>> b/drivers/media/video/ivtv/ivtv-fileops.c
>> index 1637097..8976487 100644
>> --- a/drivers/media/video/ivtv/ivtv-fileops.c
>> +++ b/drivers/media/video/ivtv/ivtv-fileops.c
>> @@ -804,7 +804,7 @@ int ivtv_v4l2_open(struct inode *inode, struct file
>> *filp)
>>  	struct ivtv_open_id *item;
>>  	struct ivtv *itv = NULL;
>>  	struct ivtv_stream *s = NULL;
>> -	int minor = MINOR(inode->i_rdev);
>> +	int minor = iminor(inode);
>>
>>  	/* Find which card this open was on */
>>  	spin_lock(&ivtv_cards_lock);
> --
> Cheers,
> Mauro
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
>