Re: [GIT PATCHES] V4L/DVB updates

Geert Uytterhoeven
2007-05-09T06:30:26Z

On Fri, 27 Apr 2007, Mauro Carvalho Chehab wrote:
> A short changelog:
>
> - New drivers:
> ivtv driver for Hauppauge PVR series and similar boards;

Can we please have proper Kconfig dependencies instead of

| #ifdef CONFIG_LIRC_I2C
| # error "This driver is not compatible with the LIRC I2C kernel configuration
| #endif /* CONFIG_LIRC_I2C */
|
| #ifndef CONFIG_PCI
| # error "This driver requires kernel PCI support."
| #endif /* CONFIG_PCI */

in drivers/media/video/ivtv/ivtv-driver.h? Especially a dependency on
CONFIG_PCI would be nice (CONFIG_LIRC_I2C doesn't exist in mainline?).

| drivers/media/video/video-buf.c: In function 'videobuf_queue_pci':
| drivers/media/video/video-buf.c:399: error: 'pci_map_sg' undeclared (first use in this function)

Probably some new driver does a select VIDEO_BUF, which overrides that
VIDEO_BUF depends on PCI?

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds