public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [RELEASE] Lguest for 2.6.21
Date: Thu, 03 May 2007 09:00:48 +1000	[thread overview]
Message-ID: <1178146848.23670.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20070502193303.GA1502@localhost.localdomain>

On Thu, 2007-05-03 at 03:33 +0800, WANG Cong wrote:
> Hi Rusty!
> 
> I found you forgot to check the return value of copy_from_user, and
> here is the fix for drivers/lguest/interrupts_and_traps.c.
> 
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

Hi Wang!

	Thanks for the patch.  This omission (in several places) was
deliberate.  We can't really do anything sensible if the user unmapped
the page.  I assume you saw a gcc warning from this code?

	We could also use lgread() in these places which does this check and
kills the guest if something goes wrong.  I'll check the benchmarks to
make sure the (slight) extra overhead doesn't cause a regression...

Thanks!
Rusty.


  parent reply	other threads:[~2007-05-02 23:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-02 14:43 [RELEASE] Lguest for 2.6.21 Rusty Russell
2007-05-02 19:33 ` WANG Cong
2007-05-02 19:59   ` WANG Cong
2007-05-02 23:00   ` Rusty Russell [this message]
2007-05-03  3:57     ` WANG Cong
2007-05-03  4:20       ` Rusty Russell
2007-05-03  5:43         ` WANG Cong
2007-05-03 16:02 ` Matt Mackall
2007-05-04  0:13   ` Rusty Russell
2007-05-04  0:43     ` Rusty Russell
2007-05-04  3:20       ` Matt Mackall
2007-05-04  3:39         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178146848.23670.6.camel@localhost.localdomain \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox