* dead CONFIG_ variables: drivers/video/
@ 2007-05-03 10:40 Robert P. J. Day
2007-05-03 11:16 ` Russell King
2007-05-03 12:04 ` Antonino A. Daplas
0 siblings, 2 replies; 6+ messages in thread
From: Robert P. J. Day @ 2007-05-03 10:40 UTC (permalink / raw)
To: Linux Kernel Mailing List
$ ../dead_config.sh drivers/video
========== FB_68328_INVERT ==========
drivers/video/68328fb.c:53:#if defined(CONFIG_FB_68328_INVERT)
========== FB_AU1200_DEVS ==========
drivers/video/au1200fb.c:52:#ifndef CONFIG_FB_AU1200_DEVS
drivers/video/au1200fb.c:53:#define CONFIG_FB_AU1200_DEVS 4
drivers/video/au1200fb.c:160:static struct au1200fb_device _au1200fb_devices[CONFIG_FB_AU1200_DEVS];
drivers/video/au1200fb.c:714: for (i = 0; i < CONFIG_FB_AU1200_DEVS; ++i) {
drivers/video/au1200fb.c:1635: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane) {
drivers/video/au1200fb.c:1730: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane)
drivers/video/au1200fb.c:1850: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane) {
========== FB_MATROX_32MB ==========
drivers/video/matrox/matroxfb_base.c:307:#ifdef CONFIG_FB_MATROX_32MB
drivers/video/matrox/matroxfb_base.c:327:#ifdef CONFIG_FB_MATROX_32MB
drivers/video/matrox/matroxfb_base.c:339:#ifdef CONFIG_FB_MATROX_32MB
drivers/video/matrox/matroxfb_base.c:1342:#ifdef CONFIG_FB_MATROX_32MB
drivers/video/matrox/matroxfb_base.c:1619:#ifdef CONFIG_FB_MATROX_32MB
drivers/video/matrox/matroxfb_DAC1064.c:1053:#ifdef CONFIG_FB_MATROX_32MB
drivers/video/matrox/matroxfb_base.h:58:#define CONFIG_FB_MATROX_32MB
drivers/video/matrox/matroxfb_base.h:466:#ifdef CONFIG_FB_MATROX_32MB
========== FB_NVIDIA_DEBUG ==========
drivers/video/nvidia/nvidia.c:40:#undef CONFIG_FB_NVIDIA_DEBUG
drivers/video/nvidia/nvidia.c:41:#ifdef CONFIG_FB_NVIDIA_DEBUG
drivers/video/nvidia/nvidia.c:50:#ifdef CONFIG_FB_NVIDIA_DEBUG
========== FB_SOFT_CURSOR ==========
drivers/video/sis/sis_main.c:1906:#ifdef CONFIG_FB_SOFT_CURSOR
========== MACH_MX1FS2 ==========
drivers/video/imxfb.c:410:#ifndef CONFIG_MACH_MX1FS2
arch/arm/tools/mach-types:486:mx1fs2 MACH_MX1FS2 MX1FS2 470
========== MACH_PIMX1 ==========
drivers/video/imxfb.c:404:#ifndef CONFIG_MACH_PIMX1
arch/arm/tools/mach-types:678:pimx1 MACH_PIMX1 PIMX1 664
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: dead CONFIG_ variables: drivers/video/
2007-05-03 10:40 dead CONFIG_ variables: drivers/video/ Robert P. J. Day
@ 2007-05-03 11:16 ` Russell King
2007-05-03 14:16 ` Sascha Hauer
2007-05-03 12:04 ` Antonino A. Daplas
1 sibling, 1 reply; 6+ messages in thread
From: Russell King @ 2007-05-03 11:16 UTC (permalink / raw)
To: Robert P. J. Day, Sascha Hauer; +Cc: Linux Kernel Mailing List
On Thu, May 03, 2007 at 06:40:03AM -0400, Robert P. J. Day wrote:
> $ ../dead_config.sh drivers/video
> ========== MACH_MX1FS2 ==========
> drivers/video/imxfb.c:410:#ifndef CONFIG_MACH_MX1FS2
> arch/arm/tools/mach-types:486:mx1fs2 MACH_MX1FS2 MX1FS2 470
> ========== MACH_PIMX1 ==========
> drivers/video/imxfb.c:404:#ifndef CONFIG_MACH_PIMX1
> arch/arm/tools/mach-types:678:pimx1 MACH_PIMX1 PIMX1 664
Sascha, any comments on these?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dead CONFIG_ variables: drivers/video/
2007-05-03 11:16 ` Russell King
@ 2007-05-03 14:16 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2007-05-03 14:16 UTC (permalink / raw)
To: Robert P. J. Day, Linux Kernel Mailing List
On Thu, May 03, 2007 at 12:16:14PM +0100, Russell King wrote:
> On Thu, May 03, 2007 at 06:40:03AM -0400, Robert P. J. Day wrote:
> > $ ../dead_config.sh drivers/video
> > ========== MACH_MX1FS2 ==========
> > drivers/video/imxfb.c:410:#ifndef CONFIG_MACH_MX1FS2
> > arch/arm/tools/mach-types:486:mx1fs2 MACH_MX1FS2 MX1FS2 470
MX1FS2 is one of our development boards, this entry can be removed
(I haven't started this board for ages)
> > ========== MACH_PIMX1 ==========
> > drivers/video/imxfb.c:404:#ifndef CONFIG_MACH_PIMX1
> > arch/arm/tools/mach-types:678:pimx1 MACH_PIMX1 PIMX1 664
This is Pavels board. I think this can also be removed. The call to
imx_gpio_mode() can also be done in the board file. If we do so we
should cc Pavel.
Sascha
--
Pengutronix - Linux Solutions for Science and Industry
Entwicklungszentrum Nord http://www.pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dead CONFIG_ variables: drivers/video/
2007-05-03 10:40 dead CONFIG_ variables: drivers/video/ Robert P. J. Day
2007-05-03 11:16 ` Russell King
@ 2007-05-03 12:04 ` Antonino A. Daplas
2007-05-03 12:35 ` Robert P. J. Day
1 sibling, 1 reply; 6+ messages in thread
From: Antonino A. Daplas @ 2007-05-03 12:04 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux Kernel Mailing List
On Thu, 2007-05-03 at 06:40 -0400, Robert P. J. Day wrote:
> $ ../dead_config.sh drivers/video
> ========== FB_68328_INVERT ==========
> drivers/video/68328fb.c:53:#if defined(CONFIG_FB_68328_INVERT)
Can be made part of Kconfig, I think
> ========== FB_AU1200_DEVS ==========
> drivers/video/au1200fb.c:52:#ifndef CONFIG_FB_AU1200_DEVS
> drivers/video/au1200fb.c:53:#define CONFIG_FB_AU1200_DEVS 4
> drivers/video/au1200fb.c:160:static struct au1200fb_device _au1200fb_devices[CONFIG_FB_AU1200_DEVS];
> drivers/video/au1200fb.c:714: for (i = 0; i < CONFIG_FB_AU1200_DEVS; ++i) {
> drivers/video/au1200fb.c:1635: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane) {
> drivers/video/au1200fb.c:1730: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane)
> drivers/video/au1200fb.c:1850: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane) {
Not sure about this one.
> ========== FB_MATROX_32MB ==========
> drivers/video/matrox/matroxfb_base.c:307:#ifdef CONFIG_FB_MATROX_32MB
> drivers/video/matrox/matroxfb_base.c:327:#ifdef CONFIG_FB_MATROX_32MB
> drivers/video/matrox/matroxfb_base.c:339:#ifdef CONFIG_FB_MATROX_32MB
> drivers/video/matrox/matroxfb_base.c:1342:#ifdef CONFIG_FB_MATROX_32MB
> drivers/video/matrox/matroxfb_base.c:1619:#ifdef CONFIG_FB_MATROX_32MB
> drivers/video/matrox/matroxfb_DAC1064.c:1053:#ifdef CONFIG_FB_MATROX_32MB
> drivers/video/matrox/matroxfb_base.h:58:#define CONFIG_FB_MATROX_32MB
> drivers/video/matrox/matroxfb_base.h:466:#ifdef CONFIG_FB_MATROX_32MB
This needs to be part of Kconfig.
> ========== FB_NVIDIA_DEBUG ==========
> drivers/video/nvidia/nvidia.c:40:#undef CONFIG_FB_NVIDIA_DEBUG
> drivers/video/nvidia/nvidia.c:41:#ifdef CONFIG_FB_NVIDIA_DEBUG
> drivers/video/nvidia/nvidia.c:50:#ifdef CONFIG_FB_NVIDIA_DEBUG
False positive, may be renamed.
> ========== FB_SOFT_CURSOR ==========
> drivers/video/sis/sis_main.c:1906:#ifdef CONFIG_FB_SOFT_CURSOR
This is dead, FB_SOFT_CURSOR is truly gone.
Thanks.
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: dead CONFIG_ variables: drivers/video/
2007-05-03 12:04 ` Antonino A. Daplas
@ 2007-05-03 12:35 ` Robert P. J. Day
2007-05-03 13:19 ` Antonino A. Daplas
0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2007-05-03 12:35 UTC (permalink / raw)
To: Antonino A. Daplas; +Cc: Linux Kernel Mailing List
On Thu, 3 May 2007, Antonino A. Daplas wrote:
> On Thu, 2007-05-03 at 06:40 -0400, Robert P. J. Day wrote:
> > $ ../dead_config.sh drivers/video
> > ========== FB_68328_INVERT ==========
> > drivers/video/68328fb.c:53:#if defined(CONFIG_FB_68328_INVERT)
>
> Can be made part of Kconfig, I think
>
> > ========== FB_AU1200_DEVS ==========
> > drivers/video/au1200fb.c:52:#ifndef CONFIG_FB_AU1200_DEVS
> > drivers/video/au1200fb.c:53:#define CONFIG_FB_AU1200_DEVS 4
> > drivers/video/au1200fb.c:160:static struct au1200fb_device _au1200fb_devices[CONFIG_FB_AU1200_DEVS];
> > drivers/video/au1200fb.c:714: for (i = 0; i < CONFIG_FB_AU1200_DEVS; ++i) {
> > drivers/video/au1200fb.c:1635: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane) {
> > drivers/video/au1200fb.c:1730: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane)
> > drivers/video/au1200fb.c:1850: for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane) {
>
> Not sure about this one.
>
> > ========== FB_MATROX_32MB ==========
> > drivers/video/matrox/matroxfb_base.c:307:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.c:327:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.c:339:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.c:1342:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.c:1619:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_DAC1064.c:1053:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.h:58:#define CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.h:466:#ifdef CONFIG_FB_MATROX_32MB
>
> This needs to be part of Kconfig.
>
> > ========== FB_NVIDIA_DEBUG ==========
> > drivers/video/nvidia/nvidia.c:40:#undef CONFIG_FB_NVIDIA_DEBUG
> > drivers/video/nvidia/nvidia.c:41:#ifdef CONFIG_FB_NVIDIA_DEBUG
> > drivers/video/nvidia/nvidia.c:50:#ifdef CONFIG_FB_NVIDIA_DEBUG
>
> False positive, may be renamed.
>
> > ========== FB_SOFT_CURSOR ==========
> > drivers/video/sis/sis_main.c:1906:#ifdef CONFIG_FB_SOFT_CURSOR
>
> This is dead, FB_SOFT_CURSOR is truly gone.
>
> Thanks.
um ... just so there's no misunderstanding, *i* don't plan on fixing
any of this, i'm just running the script and reporting it. i'm
assuming the respective maintainers can take it from here.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: dead CONFIG_ variables: drivers/video/
2007-05-03 12:35 ` Robert P. J. Day
@ 2007-05-03 13:19 ` Antonino A. Daplas
0 siblings, 0 replies; 6+ messages in thread
From: Antonino A. Daplas @ 2007-05-03 13:19 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux Kernel Mailing List
On Thu, 2007-05-03 at 08:35 -0400, Robert P. J. Day wrote:
> On Thu, 3 May 2007, Antonino A. Daplas wrote:
>
> um ... just so there's no misunderstanding, *i* don't plan on fixing
> any of this, i'm just running the script and reporting it. i'm
> assuming the respective maintainers can take it from here.
I know, just trying to elicit comments from other people.
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-05-03 14:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-03 10:40 dead CONFIG_ variables: drivers/video/ Robert P. J. Day
2007-05-03 11:16 ` Russell King
2007-05-03 14:16 ` Sascha Hauer
2007-05-03 12:04 ` Antonino A. Daplas
2007-05-03 12:35 ` Robert P. J. Day
2007-05-03 13:19 ` Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox