Re: [PATCH] lguest: don't use paravirt_probe, it's dying

Eric W. Biederman
2007-05-07T01:54:28Z

Rusty Russell <rusty@rustcorp.com.au> writes:

> On Sat, 2007-05-05 at 13:22 +1000, Rusty Russell wrote:
>> On Fri, 2007-05-04 at 20:53 -0600, Eric W. Biederman wrote:
>> > Frankly I think the least risk of problems comes from just doing a
>> > separate entry point for lguest for now. It means we don't even have
>> > to touch the common code path and later dropping will be trivially
>> > lguest specific, and certain to not break anything else.
>>
>> Hmm, I railed for so long against Xen doing that, it feels... wrong...
>> to do that now 8)
>
> And here's the patch. It's pretty trivial actually. It even worked
> first time. It applies against -mm (ie. before the "boot with P=V"
> patches I showed before).
>
> Thanks!
> Rusty.
> ==

Looks fine to me. I'm not thrilled about grepping for a know ascii
string in the kernel binary, to find the lguest entry point. But it
is simple, and it's temporary so it looks fine.

It clearly keeps us from having problems on the traditional x86 entry
point.

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

Eric