Re: [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization"

Eric W. Biederman
2007-05-04T15:21:37Z

Jeremy Fitzhardinge <jeremy@goop.org> writes:

> Eric W. Biederman wrote:
>> It's not theatrical. It makes this code path extremely brittle and
>> very hard to change, which over the long term means that it is
>> impossible to maintain. Quickly resulting in a state where any little
>> change will break something.
>
> Removing the code now is premature. I'm presuming you're proposing this
> as a .23 change, since we're planning on changing the paravirt boot to
> make use of bzImage and the boot protocol then anyway.

.22 and possibly -stable. -stable doesn't really matter because it is dead
code.

> The world isn't going to fall apart if its in there for a couple of months.

As long as the code remains dead and unused I don't really care when we purge it.

That code should NEVER EVER be used.

That code is UNMAINTAINABLE.

The code encourages random ABIs so we don't even know what we are supporting.
Once used in a production environment (i.e. where we have to support it)
it makes further changes to head.S essentially impossible.

Despite the lack of Documentation we not counting the paravirt mess in
head.S we have a well defined ABI for starting a linux-kernel. Given the
generally difficulty of changing bootloaders I have no interesting is
messing up a good thing.

Eric