From: john stultz <johnstul@us.ibm.com>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Guilherme M. Schroeder" <guilherme@centralinf.com.br>,
lkml <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Blacklist Dell Optiplex 320 from using the HPET
Date: Fri, 04 May 2007 16:27:08 -0700 [thread overview]
Message-ID: <1178321228.6094.34.camel@localhost.localdomain> (raw)
In-Reply-To: <200705050118.34711.ak@suse.de>
On Sat, 2007-05-05 at 01:18 +0200, Andi Kleen wrote:
> On Friday 04 May 2007 23:29:04 john stultz wrote:
> > One of the 2.6.21 regressions was Guilherme's problem seeing his box
> > lock up when the system detected an unstable TSC and dropped back to
> > using the HPET.
> >
> > In digging deeper, we found the HPET is not actually incrementing on
> > this system. And in fact, the reason why this issue just cropped up was
> > because of Thomas's clocksource watchdog code was comparing the TSC to
> > the HPET (which wasn't moving) and thought the TSC was broken.
> >
> > Anyway, Guliherme checked for a BIOS update and did not find one, so
> > I've added a DMI blacklist against his system so the HPET is not used.
> >
> > Many thanks to Guilherme for the slow and laborious testing that finally
> > narrowed down this issue.
>
> Before going to hard to maintain DMI black lists we should first check
> if it's a more general problem and can't it be solved better? Most likely
> that system isn't the one with this issue and I don't want to apply
> DMI patches forever.
We can give it a whirl, I just didn't want to add yet another "compare
with some other counter that may or may not work" check. In this case,
probably reading three times in a row and getting the same result would
be a clearly broken box.
> In particular: what lspci chipset does it have? If it's Intel it might be
> worth checking the datasheet if there is some "HPET stop" bit -- perhaps it
> could be fixed up.
Guilherme: Could you provide lspci output?
> We seem to have a couple of Intel systems recently with HPET trouble.
Ok, I wasn't aware it was a common issue.
thanks
-john
next prev parent reply other threads:[~2007-05-04 23:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 21:29 [PATCH] Blacklist Dell Optiplex 320 from using the HPET john stultz
2007-05-04 21:44 ` Andrew Morton
2007-05-04 21:47 ` john stultz
2007-05-04 23:19 ` Andi Kleen
2007-05-04 23:18 ` Andi Kleen
2007-05-04 23:27 ` john stultz [this message]
2007-05-05 14:26 ` Thomas Gleixner
2007-05-05 14:30 ` Thomas Gleixner
2007-05-05 15:58 ` Henrique de Moraes Holschuh
2007-05-07 18:59 ` Andreas Mohr
2007-05-07 20:41 ` Henrique de Moraes Holschuh
2007-05-05 17:24 ` Andi Kleen
2007-05-05 19:15 ` Thomas Gleixner
2007-05-05 22:05 ` Andi Kleen
2007-05-05 22:41 ` Guilherme M. Schroeder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178321228.6094.34.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=guilherme@centralinf.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox